difin commented on code in PR #6542:
URL: https://github.com/apache/hive/pull/6542#discussion_r3455312484


##########
beeline/src/java/org/apache/hive/beeline/BeeLine.java:
##########
@@ -1477,9 +1477,9 @@ public LineReader initializeLineReader(InputStream 
inputStream) throws IOExcepti
     }
 
     builder.completer(new BeeLineCompleter(this));
+    builder.highlighter(new HiveSqlHighlighter(() -> 
getOpts().getSyntaxHighlighting()));
     lineReader = builder.build();
     lineReader.unsetOpt(LineReader.Option.HISTORY_TIMESTAMPED);
-    // need to disable expansion, otherwise commands (starting with "!") will 
activate history items

Review Comment:
   It is better to leave the comment with the explanation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to