cyanzheng2926 commented on code in PR #6559: URL: https://github.com/apache/hive/pull/6559#discussion_r3463956860
########## itests/src/test/resources/testconfiguration.properties: ########## @@ -180,6 +181,7 @@ minillap.query.files=\ skip_header_footer_aggr.q,\ skip_header_footer_proj.q,\ str_to_map.q,\ + str_to_map_utf8.q,\ Review Comment: Hi @ayushtkn thanks for the review! I’ll drop the Tez golden and remove str_to_map_utf8.q from minitez.query.files, keeping only the LLAP .q.out to match str_to_map.q. One note on coverage: I've added SET commands for tez java configs to Dfile.encoding=US-ASCII which should launch tez containers with US_ASCII encoding without a POM change, whereas the LLAP driver will need -Dmaven.test.jvm.args="-Dfile.encoding=US-ASCII" for the same. With LLAP-only, precommit still validates vectorized STR_TO_MAP behavior, but the charset-specific guard is mainly for local/manual runs only since unless we add that JVM arg to CI later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
