Copilot commented on code in PR #6563:
URL: https://github.com/apache/hive/pull/6563#discussion_r3474034976
##########
ql/src/test/queries/clientpositive/show_create_table_tab_view.q:
##########
@@ -0,0 +1,46 @@
+-- Test SHOW CREATE TABLE when view is expanded text contains a tab
(HIVE-29059).
+-- IDE may replace tabs with spaces during edit.
+-- This test qfile requires actual tabs instead of soft tabs/spaces to
function properly
Review Comment:
This qtest won't run in the standard qtest suites unless it is added to the
relevant include list (e.g., `minillap.query.files` in
`itests/src/test/resources/testconfiguration.properties`). As-is, these new
`.q`/`.q.out` files appear to be unused by CI, which means the regression
coverage for HIVE-29059 won't actually execute.
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/show/ShowCreateTableOperation.java:
##########
@@ -54,7 +54,7 @@ public int execute() throws HiveException {
DDLPlanUtils ddlObj = new DDLPlanUtils();
String command;
if (table.isView()) {
- command = ddlObj.getCreateViewCommand(table, desc.isRelative());
+ command = ddlObj.getCreateViewCommand(table,
desc.isRelative()).replace("\t", "\\t");
Review Comment:
The PR description says this change is not user-facing, but `SHOW CREATE
TABLE` output for views containing literal tab characters will change from
truncated output to emitting `\t` escapes. Please update the PR description to
reflect the user-visible behavior change (even if it's a bug fix).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
