Aggarwal-Raghav commented on code in PR #6584:
URL: https://github.com/apache/hive/pull/6584#discussion_r3538474672
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/MetadataCache.java:
##########
@@ -257,39 +257,43 @@ public LlapBufferOrBuffers putFileMetadata(Object
fileKey, int length, InputStre
}
- @SuppressWarnings({ "rawtypes", "unchecked" })
+ @SuppressWarnings("unchecked")
private LlapBufferOrBuffers wrapBbForFile(LlapBufferOrBuffers result,
Review Comment:
Question? If there are any exceptions like `IOException` or
`AllocatorOutOfMemoryException` in `readIntoCacheBuffer()`/`
allocateMultiple()` shouldn't there be a `finally` block to deallocate the
previously allocated buffer memory?
In `readIntoCacheBuffer()` there is no finally block. In
`allocateMultiple()` there is finally block but will deallocate the current
buffer not previously allocated buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
