difin opened a new pull request, #6588:
URL: https://github.com/apache/hive/pull/6588
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR adds Iceberg V3 unknown type support in Hive, following the same
pattern as variant: new serde/types, parser token, schema conversion, object
inspectors, and wiring through DDL, semantic analysis, and vectorized execution.
It also adds guardrails so V3-only types (unknown, variant, nanosecond
timestamps, and nested uses) are rejected on Iceberg tables with format-version
< 3, via a new meta-hook validator on create/alter, plus negative q-tests for
create and add-column cases.
Non-Iceberg tables are blocked from using unknown, and column-type
validation is moved onto the storage handler API instead of hardcoded checks in
Table.java.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Iceberg format version 3 introduced the unknown type for placeholder columns
that only accept NULL. Hive needs explicit support for that type in its parser,
serde, schema conversion, and execution paths, or Iceberg V3 tables using
unknown fail on create, insert, select, and alter.
The format-version and storage-handler validation closes a gap where V3-only
types could be used on older Iceberg tables, or on non-Iceberg tables, leading
to invalid metadata or runtime failures instead of clear DDL errors.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes.
Users can define and use the UNKNOWN type on Iceberg tables with
format-version >= 3: create columns, insert NULL, select, and add columns via
ALTER TABLE. Hive also rejects UNKNOWN on non-Iceberg tables and on Iceberg
tables below format version 3, with explicit error messages instead of later
runtime failures.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Unit tests: TestIcebergFormatVersionValidator for V3-only type validation;
TestHiveStorageHandlerColumnTypes for storage-handler column-type checks.
Q-tests: positive unknown_type.q (create, insert, select, alter, desc on
v3); negative unknown_type_format_version.q and
unknown_type_add_column_format_version.q (reject on v2); client negative
unknown_type_non_iceberg_table.q.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
