deniskuzZ commented on code in PR #6412:
URL: https://github.com/apache/hive/pull/6412#discussion_r3557309370
##########
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:
##########
@@ -177,20 +177,22 @@ private void prepare(QueryState queryState) throws
HiveSQLException {
timeoutExecutor = Executors.newSingleThreadScheduledExecutor();
timeoutExecutor.schedule(() -> {
try {
- // The query may have already finished, failed, or been cancelled
before this task
- // fires (the executor is only shut down when the operation is
closed). Skip in that
- // case so we don't overwrite a real result/exception with a
spurious timeout message.
- if (getState().isTerminal()) {
- return null;
+ synchronized (SQLOperation.this) {
Review Comment:
why do you use synchronized here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
