rubenada commented on code in PR #6523:
URL: https://github.com/apache/hive/pull/6523#discussion_r3557358282
##########
druid-handler/pom.xml:
##########
@@ -353,10 +353,15 @@
<pattern>io.netty</pattern>
<shadedPattern>org.apache.hive.druid.io.netty</shadedPattern>
</relocation>
+ <!-- Calcite is intentionally NOT included or relocated
here. Druid 0.17.1 uses Calcite APIs
+ that are compatible with Hive's Calcite 1.42+. Including
calcite-core in the shade caused
+ SqlFunctions.class to exceed the JVM 64KB method limit
after relocation. If Druid is upgraded
+ to a version with an incompatible Calcite, this relocation
must be restored (excluding SqlFunctions,
+ or splitting the class via a source-level patch to
Calcite).
Review Comment:
yes! Exactly. I'll mention that Calcite ticket on the reviewed comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
