Copilot commented on code in PR #6589: URL: https://github.com/apache/hive/pull/6589#discussion_r3562542660
########## druid-handler/src/java/org/apache/hadoop/hive/druid/http/HiveDruidHttpClient.java: ########## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.druid.http; + +import org.apache.hadoop.hive.druid.security.DruidKerberosUtil; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.http.client.config.RequestConfig; +import org.apache.http.client.methods.CloseableHttpResponse; +import org.apache.http.client.methods.HttpEntityEnclosingRequestBase; +import org.apache.http.client.methods.HttpGet; +import org.apache.http.client.methods.HttpPost; +import org.apache.http.client.methods.HttpRequestBase; +import org.apache.http.client.methods.HttpUriRequest; +import org.apache.http.entity.ByteArrayEntity; +import org.apache.http.impl.client.CloseableHttpClient; +import org.apache.http.impl.client.HttpClients; +import org.apache.http.util.EntityUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Closeable; +import java.io.IOException; +import java.io.InputStream; +import java.net.CookieManager; +import java.net.HttpCookie; +import java.net.URI; +import java.security.PrivilegedExceptionAction; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; + +/** + * Apache HttpClient based HTTP client for Druid REST calls. + * Replaces Druid's Netty 3 HttpClientInit/KerberosHttpClient stack (HIVE-25013). + */ +public class HiveDruidHttpClient implements Closeable { + private static final Logger LOG = LoggerFactory.getLogger(HiveDruidHttpClient.class); + + private final CloseableHttpClient httpClient; + private final CookieManager cookieManager; + private final boolean kerberosEnabled; + private final ExecutorService executor; + + public HiveDruidHttpClient(int readTimeoutMs, boolean kerberosEnabled) { + this.kerberosEnabled = kerberosEnabled && UserGroupInformation.isSecurityEnabled(); + this.cookieManager = new CookieManager(); + this.httpClient = HttpClients.custom() + .setDefaultRequestConfig(RequestConfig.custom() + .setConnectTimeout(readTimeoutMs) + .setSocketTimeout(readTimeoutMs) + .setConnectionRequestTimeout(readTimeoutMs) + .build()) + .disableCookieManagement() + .build(); + this.executor = Executors.newCachedThreadPool(r -> { + Thread t = new Thread(r, "HiveDruidHttpClient"); + t.setDaemon(true); + return t; + }); + if (this.kerberosEnabled) { + LOG.info("HiveDruidHttpClient Kerberos authentication enabled"); + } + } + + public HiveDruidHttpResponse execute(HiveDruidHttpRequest request) throws IOException { + return innerExecute(request); + } + + public InputStream executeStream(HiveDruidHttpRequest request) throws IOException { + HiveDruidHttpResponse response = innerExecute(request); + return new java.io.ByteArrayInputStream(response.getBody()); + } + + public Future<InputStream> executeStreamAsync(HiveDruidHttpRequest request) { + return executor.submit(() -> executeStream(request)); + } + + private HiveDruidHttpResponse innerExecute(HiveDruidHttpRequest request) throws IOException { + HiveDruidHttpRequest current = request.copy(); + boolean shouldRetryOnUnauthorized = prepareKerberosAuth(current); + + while (true) { + try (CloseableHttpResponse response = httpClient.execute(buildHttpRequest(current))) { + int statusCode = response.getStatusLine().getStatusCode(); + storeCookies(current.getUrl().toURI(), response); + byte[] body = EntityUtils.toByteArray(response.getEntity()); + Review Comment: HiveDruidHttpClient buffers the entire HTTP entity into a byte[] via EntityUtils.toByteArray(response.getEntity()). If the response has no entity (common for some status codes), this can throw (IllegalArgumentException) or lead to unexpected failures. Consider treating a null entity as an empty body. ########## druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java: ########## @@ -440,25 +425,22 @@ private KafkaSupervisorSpec fetchKafkaIngestionSpec(Table table) { Preconditions.checkNotNull(DruidStorageHandlerUtils.getTableProperty(table, Constants.DRUID_DATA_SOURCE), "Druid Datasource name is null"); try { - StringFullResponseHolder - response = - RetryUtils.retry(() -> DruidStorageHandlerUtils.getResponseFromCurrentLeader(getHttpClient(), - new Request(HttpMethod.GET, - new URL(String.format("http://%s/druid/indexer/v1/supervisor/%s";, overlordAddress, dataSourceName))), - new StringFullResponseHandler(Charset.forName("UTF-8"))), input -> input instanceof IOException, - getMaxRetryCount()); - if (response.getStatus().equals(HttpResponseStatus.OK)) { + HiveDruidHttpResponse response = RetryUtils.retry(() -> + DruidStorageHandlerUtils.getResponseFromCurrentLeader(getHttpClient(), + new HiveDruidHttpRequest("GET", + new URL(String.format("http://%s/druid/indexer/v1/supervisor/%s";, overlordAddress, dataSourceName)))), + input -> input instanceof IOException, getMaxRetryCount()); + if (response.getStatusCode() == HiveDruidHttpResponse.SC_OK) { return JSON_MAPPER.readValue(response.getContent(), KafkaSupervisorSpec.class); // Druid Returns 400 Bad Request when not found. - } else if (response.getStatus().equals(HttpResponseStatus.NOT_FOUND) || response.getStatus() - .equals(HttpResponseStatus.BAD_REQUEST)) { + } else if (response.getStatusCode() == HiveDruidHttpResponse.SC_NOT_FOUND + || response.getStatusCode() == HiveDruidHttpResponse.SC_BAD_REQUEST) { LOG.debug("No Kafka Supervisor found for datasource[%s]", dataSourceName); Review Comment: This log statement uses printf-style `%s`, but SLF4J uses `{}` placeholders. As written, it will log the literal `%s` instead of the datasource name. ########## druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java: ########## @@ -481,24 +463,21 @@ private KafkaSupervisorSpec fetchKafkaIngestionSpec(Table table) { Preconditions.checkNotNull(DruidStorageHandlerUtils.getTableProperty(table, Constants.DRUID_DATA_SOURCE), "Druid Datasource name is null"); try { - StringFullResponseHolder - response = - RetryUtils.retry(() -> DruidStorageHandlerUtils.getResponseFromCurrentLeader(getHttpClient(), - new Request(HttpMethod.GET, new URL( - String.format("http://%s/druid/indexer/v1/supervisor/%s/status";, overlordAddress, dataSourceName))), - new StringFullResponseHandler(Charset.forName("UTF-8"))), input -> input instanceof IOException, - getMaxRetryCount()); - if (response.getStatus().equals(HttpResponseStatus.OK)) { + HiveDruidHttpResponse response = RetryUtils.retry(() -> + DruidStorageHandlerUtils.getResponseFromCurrentLeader(getHttpClient(), + new HiveDruidHttpRequest("GET", new URL( + String.format("http://%s/druid/indexer/v1/supervisor/%s/status";, overlordAddress, dataSourceName)))), + input -> input instanceof IOException, getMaxRetryCount()); + if (response.getStatusCode() == HiveDruidHttpResponse.SC_OK) { return DruidStorageHandlerUtils.JSON_MAPPER.readValue(response.getContent(), KafkaSupervisorReport.class); // Druid Returns 400 Bad Request when not found. - } else if (response.getStatus().equals(HttpResponseStatus.NOT_FOUND) || response.getStatus() - .equals(HttpResponseStatus.BAD_REQUEST)) { + } else if (response.getStatusCode() == HiveDruidHttpResponse.SC_NOT_FOUND + || response.getStatusCode() == HiveDruidHttpResponse.SC_BAD_REQUEST) { LOG.info("No Kafka Supervisor found for datasource[%s]", dataSourceName); Review Comment: This log statement uses printf-style `%s`, but SLF4J uses `{}` placeholders. As written, it will log the literal `%s` instead of the datasource name. ########## druid-handler/src/java/org/apache/hadoop/hive/druid/http/HiveDruidHttpClient.java: ########## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.druid.http; + +import org.apache.hadoop.hive.druid.security.DruidKerberosUtil; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.http.client.config.RequestConfig; +import org.apache.http.client.methods.CloseableHttpResponse; +import org.apache.http.client.methods.HttpEntityEnclosingRequestBase; +import org.apache.http.client.methods.HttpGet; +import org.apache.http.client.methods.HttpPost; +import org.apache.http.client.methods.HttpRequestBase; +import org.apache.http.client.methods.HttpUriRequest; +import org.apache.http.entity.ByteArrayEntity; +import org.apache.http.impl.client.CloseableHttpClient; +import org.apache.http.impl.client.HttpClients; +import org.apache.http.util.EntityUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Closeable; +import java.io.IOException; +import java.io.InputStream; +import java.net.CookieManager; +import java.net.HttpCookie; +import java.net.URI; +import java.security.PrivilegedExceptionAction; Review Comment: Unused import `java.net.HttpCookie` in this new class will likely trip checkstyle and should be removed. ########## druid-handler/src/java/org/apache/hadoop/hive/druid/http/HiveDruidHttpClient.java: ########## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.druid.http; + +import org.apache.hadoop.hive.druid.security.DruidKerberosUtil; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.http.client.config.RequestConfig; +import org.apache.http.client.methods.CloseableHttpResponse; +import org.apache.http.client.methods.HttpEntityEnclosingRequestBase; +import org.apache.http.client.methods.HttpGet; +import org.apache.http.client.methods.HttpPost; +import org.apache.http.client.methods.HttpRequestBase; +import org.apache.http.client.methods.HttpUriRequest; +import org.apache.http.entity.ByteArrayEntity; +import org.apache.http.impl.client.CloseableHttpClient; +import org.apache.http.impl.client.HttpClients; +import org.apache.http.util.EntityUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Closeable; +import java.io.IOException; +import java.io.InputStream; +import java.net.CookieManager; +import java.net.HttpCookie; +import java.net.URI; +import java.security.PrivilegedExceptionAction; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; + +/** + * Apache HttpClient based HTTP client for Druid REST calls. + * Replaces Druid's Netty 3 HttpClientInit/KerberosHttpClient stack (HIVE-25013). + */ +public class HiveDruidHttpClient implements Closeable { + private static final Logger LOG = LoggerFactory.getLogger(HiveDruidHttpClient.class); + + private final CloseableHttpClient httpClient; + private final CookieManager cookieManager; + private final boolean kerberosEnabled; + private final ExecutorService executor; + + public HiveDruidHttpClient(int readTimeoutMs, boolean kerberosEnabled) { + this.kerberosEnabled = kerberosEnabled && UserGroupInformation.isSecurityEnabled(); + this.cookieManager = new CookieManager(); + this.httpClient = HttpClients.custom() + .setDefaultRequestConfig(RequestConfig.custom() + .setConnectTimeout(readTimeoutMs) + .setSocketTimeout(readTimeoutMs) + .setConnectionRequestTimeout(readTimeoutMs) Review Comment: HiveDruidHttpClient relies on Apache HttpClient defaults for connection pooling (max total/per-route). Those defaults are often quite low per-route and may significantly reduce throughput compared to the previous configurable connection count. Consider wiring HiveConf.HIVE_DRUID_NUM_HTTP_CONNECTION through and configuring max connections (setMaxConnTotal/setMaxConnPerRoute). ########## druid-handler/src/java/org/apache/hadoop/hive/druid/http/HiveDruidHttpClient.java: ########## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.druid.http; + +import org.apache.hadoop.hive.druid.security.DruidKerberosUtil; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.http.client.config.RequestConfig; +import org.apache.http.client.methods.CloseableHttpResponse; +import org.apache.http.client.methods.HttpEntityEnclosingRequestBase; +import org.apache.http.client.methods.HttpGet; +import org.apache.http.client.methods.HttpPost; +import org.apache.http.client.methods.HttpRequestBase; +import org.apache.http.client.methods.HttpUriRequest; +import org.apache.http.entity.ByteArrayEntity; +import org.apache.http.impl.client.CloseableHttpClient; +import org.apache.http.impl.client.HttpClients; +import org.apache.http.util.EntityUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Closeable; +import java.io.IOException; +import java.io.InputStream; +import java.net.CookieManager; +import java.net.HttpCookie; +import java.net.URI; +import java.security.PrivilegedExceptionAction; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; + +/** + * Apache HttpClient based HTTP client for Druid REST calls. + * Replaces Druid's Netty 3 HttpClientInit/KerberosHttpClient stack (HIVE-25013). + */ +public class HiveDruidHttpClient implements Closeable { + private static final Logger LOG = LoggerFactory.getLogger(HiveDruidHttpClient.class); + + private final CloseableHttpClient httpClient; + private final CookieManager cookieManager; + private final boolean kerberosEnabled; + private final ExecutorService executor; + + public HiveDruidHttpClient(int readTimeoutMs, boolean kerberosEnabled) { + this.kerberosEnabled = kerberosEnabled && UserGroupInformation.isSecurityEnabled(); + this.cookieManager = new CookieManager(); + this.httpClient = HttpClients.custom() + .setDefaultRequestConfig(RequestConfig.custom() + .setConnectTimeout(readTimeoutMs) + .setSocketTimeout(readTimeoutMs) + .setConnectionRequestTimeout(readTimeoutMs) + .build()) + .disableCookieManagement() + .build(); + this.executor = Executors.newCachedThreadPool(r -> { + Thread t = new Thread(r, "HiveDruidHttpClient"); + t.setDaemon(true); + return t; + }); Review Comment: Using an unbounded cached thread pool for executeStreamAsync can create unlimited threads under load. Consider using a bounded ExecutorService sized to the configured max parallel connections (or using a true async HTTP client) to avoid runaway thread creation. ########## druid-handler/src/java/org/apache/hadoop/hive/druid/DruidStorageHandler.java: ########## @@ -934,33 +913,17 @@ private String getRootWorkingDir() { return rootWorkingDir; } - private static HttpClient makeHttpClient(Lifecycle lifecycle) { - final int - numConnection = - HiveConf.getIntVar(SessionState.getSessionConf(), HiveConf.ConfVars.HIVE_DRUID_NUM_HTTP_CONNECTION); - final Period - readTimeout = - new Period(HiveConf.getVar(SessionState.getSessionConf(), HiveConf.ConfVars.HIVE_DRUID_HTTP_READ_TIMEOUT)); - LOG.info("Creating Druid HTTP client with {} max parallel connections and {}ms read timeout", - numConnection, - readTimeout.toStandardDuration().getMillis()); - - final HttpClient - httpClient = - HttpClientInit.createClient(HttpClientConfig.builder() - .withNumConnections(numConnection) - .withReadTimeout(new Period(readTimeout).toStandardDuration()) - .build(), lifecycle); + private static HiveDruidHttpClient makeHttpClient() { + final Period readTimeout = new Period( + HiveConf.getVar(SessionState.getSessionConf(), HiveConf.ConfVars.HIVE_DRUID_HTTP_READ_TIMEOUT)); final boolean kerberosEnabled = HiveConf.getBoolVar(SessionState.getSessionConf(), HiveConf.ConfVars.HIVE_DRUID_KERBEROS_ENABLE); - if (kerberosEnabled && UserGroupInformation.isSecurityEnabled()) { - LOG.info("building Kerberos Http Client"); - return new KerberosHttpClient(httpClient); - } - return httpClient; + LOG.info("Creating HiveDruidHttpClient with {}ms read timeout, kerberos={}", + readTimeout.toStandardDuration().getMillis(), kerberosEnabled); + return new HiveDruidHttpClient((int) readTimeout.toStandardDuration().getMillis(), kerberosEnabled); Review Comment: DruidStorageHandler.makeHttpClient() no longer reads HiveConf.ConfVars.HIVE_DRUID_NUM_HTTP_CONNECTION, so the configured max parallel connections setting is ignored. With the new Apache HttpClient implementation, not honoring this can reduce throughput and change operational behavior. Consider reading the conf var here and passing it into HiveDruidHttpClient so it can configure both connection pooling and async executor sizing. ########## druid-handler/src/java/org/apache/hadoop/hive/druid/http/HiveDruidHttpClient.java: ########## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.druid.http; + +import org.apache.hadoop.hive.druid.security.DruidKerberosUtil; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.http.client.config.RequestConfig; +import org.apache.http.client.methods.CloseableHttpResponse; +import org.apache.http.client.methods.HttpEntityEnclosingRequestBase; +import org.apache.http.client.methods.HttpGet; +import org.apache.http.client.methods.HttpPost; +import org.apache.http.client.methods.HttpRequestBase; +import org.apache.http.client.methods.HttpUriRequest; +import org.apache.http.entity.ByteArrayEntity; +import org.apache.http.impl.client.CloseableHttpClient; +import org.apache.http.impl.client.HttpClients; +import org.apache.http.util.EntityUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Closeable; +import java.io.IOException; +import java.io.InputStream; +import java.net.CookieManager; +import java.net.HttpCookie; +import java.net.URI; +import java.security.PrivilegedExceptionAction; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; + +/** + * Apache HttpClient based HTTP client for Druid REST calls. + * Replaces Druid's Netty 3 HttpClientInit/KerberosHttpClient stack (HIVE-25013). + */ +public class HiveDruidHttpClient implements Closeable { + private static final Logger LOG = LoggerFactory.getLogger(HiveDruidHttpClient.class); + + private final CloseableHttpClient httpClient; + private final CookieManager cookieManager; + private final boolean kerberosEnabled; + private final ExecutorService executor; + + public HiveDruidHttpClient(int readTimeoutMs, boolean kerberosEnabled) { + this.kerberosEnabled = kerberosEnabled && UserGroupInformation.isSecurityEnabled(); + this.cookieManager = new CookieManager(); + this.httpClient = HttpClients.custom() + .setDefaultRequestConfig(RequestConfig.custom() + .setConnectTimeout(readTimeoutMs) + .setSocketTimeout(readTimeoutMs) + .setConnectionRequestTimeout(readTimeoutMs) + .build()) + .disableCookieManagement() + .build(); + this.executor = Executors.newCachedThreadPool(r -> { + Thread t = new Thread(r, "HiveDruidHttpClient"); + t.setDaemon(true); + return t; + }); + if (this.kerberosEnabled) { + LOG.info("HiveDruidHttpClient Kerberos authentication enabled"); + } + } + + public HiveDruidHttpResponse execute(HiveDruidHttpRequest request) throws IOException { + return innerExecute(request); + } + + public InputStream executeStream(HiveDruidHttpRequest request) throws IOException { + HiveDruidHttpResponse response = innerExecute(request); + return new java.io.ByteArrayInputStream(response.getBody()); + } Review Comment: executeStream() currently materializes the full response body into memory (via innerExecute() + ByteArrayInputStream). For Druid query responses this can be very large and defeats streaming parsing, risking high memory usage/OOM compared to the previous InputStreamResponseHandler behavior. It would be safer to return a streaming InputStream backed by the HttpEntity and ensure the underlying CloseableHttpResponse is closed when the stream is closed. ########## druid-handler/pom.xml: ########## @@ -34,6 +34,14 @@ <groupId>com.fasterxml.jackson.dataformat</groupId> <artifactId>jackson-dataformat-smile</artifactId> </dependency> Review Comment: pom.xml says dependencies are kept sorted by (groupId, artifactId), but the Jackson dependencies are currently out of order (dataformat is listed before core). This makes future diffs noisier and can violate repo conventions/tools that assume sorted deps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
