okumin commented on code in PR #6592:
URL: https://github.com/apache/hive/pull/6592#discussion_r3576626984
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/properties/HMSPropertyManager.java:
##########
@@ -45,14 +51,13 @@ public class HMSPropertyManager extends PropertyManager {
/** Table maintenance operation type. */
public enum MaintenanceOpType {
- COMPACTION,
- SNAPSHOT_EXPIRY,
- STATS_REBUILD,
- MV_BUILD,
- MV_REFRESH,
- SHUFFLE_TO_NEW_PART,
- RECOMPRESS,
- REORG
+ EXPIRE_SNAPSHOT,
+ REWRITE_DATA_FILES,
+ COMPRESS_DATA_FILES,
+ REWRITE_MANIFEST,
+ DELETE_ORPHAN_FILES,
+ REWRITE_POSITION_DELETE,
+ COMPUTE_TABLE_STATS
Review Comment:
Could you explain the enum changes? I understand we can change them as the
original values are not used yet. However, I am not confident about why the new
values are better than the old ones. One option is to separate the PR and
involve Dmitriy or someone more familiar with maintenance tasks there. I can
quickly give you +1 for the JEXL upgrade, but I may need to learn something to
approve this list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
