maheshrajus opened a new pull request, #6607:
URL: https://github.com/apache/hive/pull/6607
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
- In **StringGroupConcatColCol.evaluate()**, on the "no nulls in either
input" branch, set outV.noNulls = true before writing. (Matches what the
sibling StringGroupColConcatStringScalar / StringScalarConcatStringGroupCol
already do)
- Added two JUnit tests in TestVectorStringConcat that pre-set
outV.noNulls = false (simulating a prior batch that carried NULLs), then assert
the flag is restored after evaluate()
### Why are the changes needed?
The output BytesColumnVector(outV) is reused across batches. A previous
batch that went through a null-carrying branch leaves outV.noNulls = false. The
no-nulls branch wrote per-row isNull[i] = false but never reset outV.noNulls =
true, so downstream vectorized consumers that utilizes on **noNulls** treated
fully-populated rows as NULL and producing NULL for a || b on rows where both
operands were non-null.
More code level details we can find in the jira:
https://issues.apache.org/jira/browse/HIVE-28503
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
With added unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
