kokila-19 commented on code in PR #6603:
URL: https://github.com/apache/hive/pull/6603#discussion_r3594566893
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -796,6 +805,50 @@ private static PartitionStats
recordToPartitionStats(StructLike record) {
return stats;
}
+ /**
+ * Merges partition stats counters from {@code right} into {@code left}.
+ * Replicates package-private {@code PartitionStats.appendStats()} removed
in Iceberg 1.11.
+ */
+ private static PartitionStats mergePartitionStats(PartitionStats left,
PartitionStats right) {
Review Comment:
`could you please ask in iceberg why appendStats was made private?
`
https://github.com/apache/iceberg/pull/14119 -> says they are modifying
deprecated method to package-private.
Also, appendStats() is in **PartitionStats.java** which will be removed from
1.12.0 onwards. So we will to update them as well later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
