rubenada commented on code in PR #6523:
URL: https://github.com/apache/hive/pull/6523#discussion_r3612831685
##########
ql/pom.xml:
##########
@@ -365,6 +365,24 @@
<artifactId>hadoop-yarn-client</artifactId>
<optional>true</optional>
</dependency>
+ <!--
+ Runtime dependencies required by
org.apache.calcite.avatica:avatica-core:1.28.0
+ (pulled in by Calcite 1.42+): Avatica now uses Apache HttpComponents 5
for its
+ HTTP/JDBC transport, so hive-exec must bundle httpcore5/httpclient5 or
tests fail
+ with "NoClassDefFoundError: org/apache/hc/core5/util/Timeout". Avatica
declares
+ these as <scope>runtime</scope> transitively, but they must be declared
here
+ explicitly because Hive's enforcer bans org.apache.hc.core5/client5.**
imports
+ elsewhere and the hive-exec shade plugin only bundles ql-level
dependencies.
+ Can be removed once Hive migrates to HttpComponents 5 across the board.
+ -->
+ <dependency>
+ <groupId>org.apache.httpcomponents.core5</groupId>
+ <artifactId>httpcore5</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.httpcomponents.client5</groupId>
+ <artifactId>httpclient5</artifactId>
+ </dependency>
Review Comment:
I've added the runtime scope, and also I've changed the comment, hopefully
is more clear now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
