architjainjain commented on code in PR #6619:
URL: https://github.com/apache/hive/pull/6619#discussion_r3622712703
##########
serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java:
##########
@@ -52,7 +52,13 @@ public void testTypeInfoParser() {
"decimal(10, 2)",
"decimal(10, 2 )",
"decimal( 10, 2 )",
- "struct<user id:int,user group: int>"
+ "struct<user id:int,user group: int>",
+ // struct field names with special characters (Iceberg partition
column names)
+ "struct<gpa_!@#$%^&*():double>",
+ "struct<!@#$%^&*()_age:int>",
+ "struct<name:string,!@#$%^&*()_age:int,gpa_!@#$%^&*():double>",
+ "struct<name:string,gpa_!@#$%^&*():double>",
+ "struct<gpa_!@#$%^&*():double,age:int>"
Review Comment:
@deniskuzZ I have added the test here, although i will add other suggested
test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
