zabetak commented on code in PR #6615:
URL: https://github.com/apache/hive/pull/6615#discussion_r3637702360
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java:
##########
@@ -545,7 +476,7 @@ private ImmutableBitSet generateNewGroupset(Aggregate
aggregate, ImmutableBitSet
*
* This is mainly done so that hive is able to push down queries with
* group by 'constant key with type not supported by druid' into druid.
- *
+ * TODO: If relevant only for Druid the review for removal
Review Comment:
Yes, I checked the history from when the method was introduced and it
affected various .q files not necessarily Druid related. I guess we will
continue using it for the time being.
(https://github.com/apache/hive/pull/6615/commits/ab22a20c2edd2ec1687f351b3c9282f49e68ae82)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
