kokila-19 commented on code in PR #6396:
URL: https://github.com/apache/hive/pull/6396#discussion_r3645843968
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -141,15 +206,61 @@ protected void doRefresh() {
}
refreshFromMetadataLocation(metadataLocation, metadataRefreshMaxRetries);
+ if (tableKeyIdFromHMS != null) {
+ tableKeyId = tableKeyIdFromHMS;
+ encryptionDekLength = (dekLengthFromHMS != null) ?
+ Integer.parseInt(dekLengthFromHMS) :
+ TableProperties.ENCRYPTION_DEK_LENGTH_DEFAULT;
+
+ if (current() != null) {
Review Comment:
This null check and order of calling checkIntegrityForEncryption() is not
same as in Iceberg
https://github.com/apache/iceberg/blob/6976e020b894f6a6777704df2b8c4458cb291ae9/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java#L209
Was this intentional to add NULL check ? Is it necessary ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
