hemanthumashankar0511 commented on PR #6587: URL: https://github.com/apache/hive/pull/6587#issuecomment-5082675723
Hi @ayushtkn , I originally created individual subtasks for each DBMS, but the ticket reporter Stamatis Zampetakis advised me that individual subtasks were unnecessary since the test structure is the same across all DBMS, he suggested covering all databases in a single test instead. Based on that, I resolved the subtasks as "Feedback Received" (no Jira comment thread since the guidance came over Slack) and referenced the parent ticket directly. What this PR covers: `TestGenericJdbcDatabaseAccessor` — expanded with H2-backed tests for all DatabaseAccessor interface methods: `getColumnNames, getColumnTypes, getTotalNumberOfRecords, getRecordIterator` (with partitioning), `getBounds, getRecordWriter, addBoundaryToQuery, needColumnQuote, close` `TestDatabaseAccessorByDatabaseType` — new parameterized class covering all 8 DBMS (MySQL, Postgres, Oracle, MsSql, DB2, Derby, Hive, JethroData) for dialect SQL generation (addLimitToQuery, addLimitAndOffsetToQuery, constructQuery, getMetaDataQuery, needColumnQuote), factory routing, and H2 smoke integration tests for 6 compatible DBMS Remaining gaps: getColumnTypes, getTotalNumberOfRecords, and getRecordWriter are only tested generically (not per-DBMS dialect), and Oracle/MSSQL are excluded from H2 smoke tests due to dialect incompatibility. Should I create a subtask under the parent ticket to track these current changes and resolve that, or would you prefer I resolve the parent ticket directly with this PR and create a follow-up subtask for the remaining gaps? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
