csringhofer commented on code in PR #6644:
URL: https://github.com/apache/hive/pull/6644#discussion_r3660217644
##########
iceberg/iceberg-handler/src/test/queries/positive/variant_type_projection.q:
##########
@@ -0,0 +1,66 @@
+-- SORT_QUERY_RESULTS
+set hive.explain.user=false;
+
+drop table if exists variant_proj;
+
+CREATE EXTERNAL TABLE variant_proj (
+ id INT,
+ data VARIANT
+) STORED BY ICEBERG
+TBLPROPERTIES (
+ 'format-version'='3'
+);
+
+INSERT INTO variant_proj VALUES
+(1, parse_json('{"name": "John", "age": 30}')),
+(2, parse_json('[1, 2, 3]')),
+(3, parse_json('"plain string"')),
+(4, parse_json('42'));
Review Comment:
Can Hive create VARIANTs from other types?
An interesting case is BINARY. Impala and Trino base64 encodes it, but you
can't just create it by parsing JSON
##########
service-rpc/if/TCLIService.thrift:
##########
Review Comment:
Should the new type get a new version? Note that I don't understand how this
client interface versioning works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
