abstractdog commented on code in PR #6642:
URL: https://github.com/apache/hive/pull/6642#discussion_r3665822257
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/ParsedOutputFileName.java:
##########
@@ -31,20 +31,23 @@
* 00001_02
* 00001_02.gz
* 00001_02.zlib.gz
- * 00001_02_copy_1
+ * 00001_02_copy_1 (numeric copy suffix, HDFS-style)
* 00001_02_copy_1.gz
+ * 00001_02_copy_abcd1234 (per-query uniqueness tag as copy
suffix, HIVE-28822,
+ * used on unstable-rename filesystems)
+ * 00001_02_copy_abcd1234.gz
* <p>
* All the components are here:
* tmp_(taskPrefix)00001_02_copy_1.zlib.gz
*/
public class ParsedOutputFileName {
private static final Pattern COPY_FILE_NAME_TO_TASK_ID_REGEX =
Pattern.compile(
- "^(.*?)?" + // any prefix
- "(\\(.*\\))?" + // taskId prefix
- "([0-9]+)" + // taskId
- "(?:_([0-9]{1,6}))?" + // _<attemptId> (limited to 6 digits)
- "(?:_copy_([0-9]{1,6}))?" + // copy file index
- "(\\..*)?$"); // any suffix/file extension
+ "^(.*?)?" + /* any prefix */
+ "(\\(.*\\))?" + /* taskId prefix */
+ "(\\d+)" + /* taskId */
+ "(?:_(\\d{1,6}))?" + /* _<attemptId> (limited to 6 digits) */
+ "(?:_copy_(\\d{1,6}|[\\da-fA-F]{8}))?" + /* copy suffix: numeric
counter, or 8-hex tag (HIVE-28822) */
Review Comment:
just Claude things :) I liked that for context, however it became too much,
removed in
https://github.com/apache/hive/pull/6642/changes/aab3c3b6b0d75bfa8ead3f10306460ff0dc93e33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
