abstractdog commented on PR #6642: URL: https://github.com/apache/hive/pull/6642#issuecomment-5115673367
> The tag is per-query, but a single query can move multiple files with the same basename into the same destination directory, isn't it? > > ``` > INSERT INTO t SELECT ... UNION ALL SELECT .. > ``` > > FS > > ``` > -ext-10000/HIVE_UNION_SUBDIR_1/000000_0, > --> 000000_0_copy_<tag> > -ext-10000/HIVE_UNION_SUBDIR_2/000000_0 > ``` > > On master, the exists-probe loop resolves it (000000_0 + 000000_0_copy_1); under the PR both legs compute the same 000000_0_copy_ and collide > > [HIVE-21100](https://issues.apache.org/jira/browse/HIVE-21100) seems to add branch index, so we might be sorted ack, this has to be sorted now, because "the exists-probe loop resolves it" is just true to a certain extent, which is still subject to the reported problem, which is the race in multiple places in the copy++ loop: I'm going to address this as well and let you know -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
