cyanzheng2926 opened a new pull request, #6670:
URL: https://github.com/apache/hive/pull/6670
For embedded metastore, session level SET updates HiveConf in place, but
embedded ObjectStore can keep a stale Configuration reference after an earlier
column stats fetch, leaving describe formatted histogram values empty despite
metastore.stats.fetch.kll=true. Rebind the embedded handler and ObjectStore when
stats fetch keys change in embedded mode only. Add order-dependent qfile
reproducers verified with TestMiniLlapCliDriver.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
When `metastore.stats.fetch.kll=true` is set after an earlier `DESCRIBE
FORMATTED` on a column in the same session, histogram may be shown as empty on
a subsequent `DESCRIBE FORMATTED` even when kll data exists in the metastore.
This PR fixes that for embedded metastore by re-syncing the embedded handler
and ObjectStore configuration after session level config set for stats-fetch
flags.
Added `syncEmbeddedHandlerConf` method under `IMetaStoreClient` (default
no-op), delegate through `MetaStoreClientWrapper`, implemented in
`ThriftHiveMetaStoreClient` to rebind embedded handler/ObjectStore when
performing set on stats-fetch keys.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
For embedded metastore, session level set updates session HiveConf in place,
but embedded ObjectStore can retain a stale config reference after an earlier
column stats fetch, causing inconsistency between display and actual metadata
storage.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. For embedded metastore sessions, set metastore.stats.fetch.kll=true
after an earlier column desc formatted statement now correctly populates
histogram values on subsequent desc formatted commands.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Added the qtest files using the examples from the jira
https://issues.apache.org/jira/browse/HIVE-29301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
