g3rg0 commented on PR #6677: URL: https://github.com/apache/hive/pull/6677#issuecomment-5201565414
> @g3rg0 : tests passed, patch overall looks good to me can you please take care of the sonarqube and copilot warnings where they make sense? @abstractdog Sure, I'm working on it. [There's one](https://github.com/apache/hive/pull/6677#discussion_r3720856778) that I feel is a bit risky, so I'd like to test that out, and I need a little time to do that. > When catching InterruptedException, the thread interrupt flag should be restored (Thread.currentThread().interrupt()), otherwise higher-level cancellation/shutdown logic may not observe the interrupt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
