srbiswal opened a new pull request, #6682:
URL: https://github.com/apache/hive/pull/6682

   ### What changes were proposed in this pull request?
   `hive.repl.cm.retain` declared a DAYS-based `TimeValidator`, while the
   equivalent metastore config `metastore.repl.cm.retain` uses a HOURS base
   unit. As a result a unit-less value (e.g. `10`) was documented as days on
   the HiveConf side but interpreted as hours by the metastore.
   
   This PR changes the HiveConf `TimeValidator` to `HOURS` and expresses the
   default as `240h` so the declared unit and value match the metastore
   counterpart. A `TestHiveConf` case is added asserting the default resolves
   to 10 days and that unit-less values are interpreted in hours.
   
   ### Why are the changes needed?
   To remove the misleading unit mismatch between the two equivalent configs.
   
   ### Does this PR introduce any user-facing change?
   No functional change. `HiveConf.REPL_CM_RETAIN` is not read anywhere via
   `getTimeVar`, and the default is unchanged (`240h` == `10d`). This is a
   documentation/consistency change only.
   
   ### How was this patch tested?
   Added `TestHiveConf#testReplCmRetainTimeUnit`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to