illiabarbashov-sketch commented on code in PR #6652: URL: https://github.com/apache/hive/pull/6652#discussion_r3736587906
########## .github/workflows/beeline-release.yml: ########## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Beeline Native Installer Release + +on: + workflow_dispatch: + inputs: + release_tag: + description: 'GitHub release tag to upload artifacts to. Leave empty to skip release upload.' + required: false + default: '' + type: string + +permissions: + contents: write + +jobs: + build: + strategy: + fail-fast: false + matrix: + include: + - os: macos-13 + label: macos-x64 + artifact_glob: beeline/target/installer/x64/*.dmg + - os: macos-latest + label: macos-arm64 + artifact_glob: beeline/target/installer/arm64/*.dmg + - os: ubuntu-latest + label: linux-x64 + artifact_glob: beeline/target/installer/x64/*.deb + - os: windows-latest + label: windows-x64 + artifact_glob: beeline/target/installer/x64/*.msi + + runs-on: ${{ matrix.os }} + # Bounds total job time (queue + execution). Notably guards against macos-13 + # runner-pool starvation as GitHub drains its capacity ahead of deprecation. + timeout-minutes: 60 + steps: + - uses: actions/checkout@v3 + + - name: Set up JDK 21 + uses: actions/setup-java@v5 + with: + java-version: '21' + distribution: temurin + cache: maven + + - name: Disable WSL bash stub so Git Bash wins (Windows only) + if: runner.os == 'Windows' + shell: pwsh + run: | + $stub = "C:\Windows\System32\bash.exe" + if (Test-Path $stub) { + Write-Host "Taking ownership of $stub" + takeown.exe /F $stub /A | Out-Null + icacls.exe $stub /grant "*S-1-5-32-544:F" | Out-Null # Administrators group SID + Rename-Item -Path $stub -NewName "bash.exe.disabled" -Force + } + "C:\Program Files\Git\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append + Write-Host "bash now resolves to:" + where.exe bash + bash --version + + - name: Build Beeline installer + run: mvn package -pl beeline -am -DskipTests -P native-installer Review Comment: Do you think we would need this? I mean, if we just rename native-isntaller to dist profile for beeline, wouldn't it triggered the jpackage native app on every nightly build? I thought it was something to avoid. Current hive building command, to what I know, is `mvn install -Dtest=noMatches -Pdist -pl packaging -am` Beeline currently doesn't have dist profile so it's just get built with the install command. If we change native-installer profile to dist the earlier hive build command will propagate the dist profile to beeline and jpackage will get activated. And we should be sure that Jenkins agent is able to run that. Also this will extend the time for nightly build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
