maheshrajus commented on PR #6643: URL: https://github.com/apache/hive/pull/6643#issuecomment-5266664012
> the fix makes sense to me: let's not gather stats if the compactor tests don't rely on them, can make this comment more concise? > > ``` > //Post-compaction stats gathering runs an ANALYZE TABLE query through the Driver, > // which triggers SessionState.setupAuth() and fails here with a ClassNotFoundException: > // data/conf/hive-site.xml points hive.security.authorization.manager at > // SQLStdHiveAuthorizerFactoryForTest, but that class lives in itests/util which > // isn't on the ql test classpath. StatsUpdater swallows the failure so tests still pass. > // Disable stats by default as these tests do not assert on the stats that StatsUpdater.gatherStats produces. > ``` > > Later readers are not interested in this detail; they need to know the basic facts like: "Disable stats by default as these tests do not assert on the stats that StatsUpdater.gatherStats produces." you can also add a minor note that, enabling these would need a proper setup of an authorizer @abstractdog Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
