okumin commented on code in PR #6668:
URL: https://github.com/apache/hive/pull/6668#discussion_r3767490101
##########
checkstyle/suppressions.xml:
##########
@@ -26,9 +27,9 @@
<!-- Ignore JDBM code -->
<suppress checks=".*" files="ql\/util\/jdbm"/>
<!-- Copies of an external libraries -->
- <suppress checks="RegexpHeader"
files="serde\/src\/java\/org\/apache\/hadoop\/hive\/serde2\/lazy\/fast\/StringToDouble\.java"/>
- <suppress checks="RegexpHeader"
files="llap-server\/src\/java\/org\/apache\/hadoop\/hive\/llap\/daemon\/impl\/PriorityBlockingDeque\.java"/>
+ <suppress checks="RegexpHeader|Header"
files="serde\/src\/java\/org\/apache\/hadoop\/hive\/serde2\/lazy\/fast\/StringToDouble\.java"/>
+ <suppress checks="RegexpHeader|Header"
files="llap-server\/src\/java\/org\/apache\/hadoop\/hive\/llap\/daemon\/impl\/PriorityBlockingDeque\.java"/>
Review Comment:
```suggestion
<suppress checks="Header"
files="serde\/src\/java\/org\/apache\/hadoop\/hive\/serde2\/lazy\/fast\/StringToDouble\.java"/>
<suppress checks="Header"
files="llap-server\/src\/java\/org\/apache\/hadoop\/hive\/llap\/daemon\/impl\/PriorityBlockingDeque\.java"/>
```
Do we no longer need RegexpHeader here?
##########
checkstyle/suppressions.xml:
##########
@@ -26,9 +27,9 @@
<!-- Ignore JDBM code -->
<suppress checks=".*" files="ql\/util\/jdbm"/>
<!-- Copies of an external libraries -->
- <suppress checks="RegexpHeader"
files="serde\/src\/java\/org\/apache\/hadoop\/hive\/serde2\/lazy\/fast\/StringToDouble\.java"/>
- <suppress checks="RegexpHeader"
files="llap-server\/src\/java\/org\/apache\/hadoop\/hive\/llap\/daemon\/impl\/PriorityBlockingDeque\.java"/>
+ <suppress checks="RegexpHeader|Header"
files="serde\/src\/java\/org\/apache\/hadoop\/hive\/serde2\/lazy\/fast\/StringToDouble\.java"/>
+ <suppress checks="RegexpHeader|Header"
files="llap-server\/src\/java\/org\/apache\/hadoop\/hive\/llap\/daemon\/impl\/PriorityBlockingDeque\.java"/>
<!-- Generated by Avro -->
- <suppress checks="RegexpHeader"
files="hbase-handler\/src\/test\/org\/apache\/hadoop\/hive\/hbase\/avro\/.*\.java"/>
- <suppress checks="RegexpHeader"
files="kafka-handler\/src\/test\/gen\/org\/apache\/hadoop\/hive\/kafka\/SimpleRecord\.java"/>
+ <suppress checks="RegexpHeader|Header"
files="hbase-handler\/src\/test\/org\/apache\/hadoop\/hive\/hbase\/avro\/.*\.java"/>
+ <suppress checks="RegexpHeader|Header"
files="kafka-handler\/src\/test\/gen\/org\/apache\/hadoop\/hive\/kafka\/SimpleRecord\.java"/>
Review Comment:
```suggestion
<suppress checks="Header"
files="hbase-handler\/src\/test\/org\/apache\/hadoop\/hive\/hbase\/avro\/.*\.java"/>
<suppress checks="Header"
files="kafka-handler\/src\/test\/gen\/org\/apache\/hadoop\/hive\/kafka\/SimpleRecord\.java"/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
