thomasrebele commented on code in PR #6523:
URL: https://github.com/apache/hive/pull/6523#discussion_r3774978809
##########
ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out:
##########
@@ -2301,10 +2307,10 @@ STAGE PLANS:
Map Operator Tree:
TableScan
alias: srcpart
- filterExpr: UDFToDouble(hr) is not null (type: boolean)
+ filterExpr: (UDFToDouble(hr) * 2.0D) is not null (type:
boolean)
Review Comment:
Afaik, multiplication with a constant should not change the nullability. I
guess this is a regression caused by one of Calcite's IS (NOT) NULL related
commits. According to
[3)](https://github.com/apache/hive/pull/6523#issue-4578568558) it's related to
one of the following tickets:
* [[CALCITE-7145](https://issues.apache.org/jira/browse/CALCITE-7145)]
RexSimplify should not simplify IS NULL(10/0)
* [[CALCITE-7296](https://issues.apache.org/jira/browse/CALCITE-7296)]
RexSimplify should not simplify IS (NOT) NULL(CAST(10/0 AS BIGINT))
* [[CALCITE-7295](https://issues.apache.org/jira/browse/CALCITE-7295)]
RexSimplify should simplify a division with a NULL argument
* [[CALCITE-7032](https://issues.apache.org/jira/browse/CALCITE-7032)]
Simplify 'NULL>ALL (ARRAY[1,2,NULL])' to 'NULL'
I think we should look into avoiding the multiplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
