ramitg254 commented on code in PR #6658:
URL: https://github.com/apache/hive/pull/6658#discussion_r3781530482
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AlterViewAddPartitionAnalyzer.java:
##########
@@ -79,10 +89,10 @@ protected void postProcess(TableName tableName, Table
table, AlterTableAddPartit
} else {
where.append(" AND ");
}
+ FieldSchema partCol = table.getColumnByName(entry.getKey());
Review Comment:
Partitioned views are only supported native hive over any kind of table so
by non native flow I meant native hive view over non native iceberg table and
added test cases for that here bc9abdf96dc80b1d19eda233a58570cfe9c519c2
but iceberg logical views backed by `iceberg view catalog` introduced in
https://github.com/apache/hive/pull/6449 does not support hive-style ddl
partitioning like add, drop partition yet so that is **out of scope** of this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
