github-advanced-security[bot] commented on code in PR #6655: URL: https://github.com/apache/hive/pull/6655#discussion_r3809583442
########## itests/util/src/main/java/org/apache/hadoop/hive/cli/GcsOAuthTokenMock.java: ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.cli; + +import com.sun.net.httpserver.HttpExchange; +import com.sun.net.httpserver.HttpHandler; +import com.sun.net.httpserver.HttpServer; +import com.sun.net.httpserver.HttpsServer; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.net.InetSocketAddress; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.Path; +import java.security.KeyStore; +import java.util.concurrent.TimeUnit; +import javax.net.ssl.KeyManagerFactory; +import javax.net.ssl.SSLContext; + +/** + * Minimal Google OAuth2/STS token endpoint mock for Gravitino {@code gcs-token} credential vending. + * + * <p>Runs two endpoints on separate ports: + * <ul> + * <li>Plain HTTP {@code POST /token} for service-account {@code token_uri}</li> + * <li>HTTPS {@code POST /v1/token} with {@code CN=sts.googleapis.com} for Google STS</li> + * </ul> + * The test wires {@link GcsStsProxyContainer} to forward {@code sts.googleapis.com:443} to the + * HTTPS port, and imports {@link #getCertificatePath()} into the Gravitino container truststore. + */ +public final class GcsOAuthTokenMock implements AutoCloseable { + + /** Token value returned to Gravitino; fake-gcs-server does not validate it. */ + public static final String ACCESS_TOKEN = "gcs-test-access-token"; + private static final String STS_CN = "sts.googleapis.com"; + static final String HOST_GATEWAY = GcsFakeServerContainers.HOST_GATEWAY; + + private static final byte[] OAUTH_TOKEN_RESPONSE = String.format( + "{\"access_token\":\"%s\",\"expires_in\":3600,\"token_type\":\"Bearer\"}", + ACCESS_TOKEN).getBytes(StandardCharsets.UTF_8); + + private static final byte[] STS_TOKEN_RESPONSE = String.format( + "{\"access_token\":\"%s\",\"issued_token_type\":\"urn:ietf:params:oauth:token-type:access_token\"," + + "\"token_type\":\"Bearer\",\"expires_in\":3600}", + ACCESS_TOKEN).getBytes(StandardCharsets.UTF_8); + + private HttpServer httpServer; + private HttpsServer httpsServer; + private Path certificatePath; + private Path workDir; + + /** Starts HTTP and HTTPS servers on ephemeral ports. */ + public void start() throws Exception { + workDir = Files.createTempDirectory("gcs-oauth-mock-"); Review Comment: ## SonarCloud / Temporary files should not be created in publicly writable directories <!--SONAR_ISSUE_KEY:AaADnYk4k1xzxvxQYwvl-->Make sure publicly writable directories are used safely here. <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_hive&issues=AaADnYk4k1xzxvxQYwvl&open=AaADnYk4k1xzxvxQYwvl&pullRequest=6655";>SonarQube Cloud</a></p> [Show more details](https://github.com/apache/hive/security/code-scanning/451) ########## itests/util/src/main/java/org/apache/hadoop/hive/cli/GcsOAuthTokenMock.java: ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.cli; + +import com.sun.net.httpserver.HttpExchange; +import com.sun.net.httpserver.HttpHandler; +import com.sun.net.httpserver.HttpServer; +import com.sun.net.httpserver.HttpsServer; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.net.InetSocketAddress; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.Path; +import java.security.KeyStore; +import java.util.concurrent.TimeUnit; +import javax.net.ssl.KeyManagerFactory; +import javax.net.ssl.SSLContext; + +/** + * Minimal Google OAuth2/STS token endpoint mock for Gravitino {@code gcs-token} credential vending. + * + * <p>Runs two endpoints on separate ports: + * <ul> + * <li>Plain HTTP {@code POST /token} for service-account {@code token_uri}</li> + * <li>HTTPS {@code POST /v1/token} with {@code CN=sts.googleapis.com} for Google STS</li> + * </ul> + * The test wires {@link GcsStsProxyContainer} to forward {@code sts.googleapis.com:443} to the + * HTTPS port, and imports {@link #getCertificatePath()} into the Gravitino container truststore. + */ +public final class GcsOAuthTokenMock implements AutoCloseable { + + /** Token value returned to Gravitino; fake-gcs-server does not validate it. */ + public static final String ACCESS_TOKEN = "gcs-test-access-token"; + private static final String STS_CN = "sts.googleapis.com"; + static final String HOST_GATEWAY = GcsFakeServerContainers.HOST_GATEWAY; + + private static final byte[] OAUTH_TOKEN_RESPONSE = String.format( + "{\"access_token\":\"%s\",\"expires_in\":3600,\"token_type\":\"Bearer\"}", + ACCESS_TOKEN).getBytes(StandardCharsets.UTF_8); + + private static final byte[] STS_TOKEN_RESPONSE = String.format( + "{\"access_token\":\"%s\",\"issued_token_type\":\"urn:ietf:params:oauth:token-type:access_token\"," + + "\"token_type\":\"Bearer\",\"expires_in\":3600}", + ACCESS_TOKEN).getBytes(StandardCharsets.UTF_8); + + private HttpServer httpServer; + private HttpsServer httpsServer; + private Path certificatePath; + private Path workDir; + + /** Starts HTTP and HTTPS servers on ephemeral ports. */ + public void start() throws Exception { + workDir = Files.createTempDirectory("gcs-oauth-mock-"); + Path keyPath = workDir.resolve("key.pem"); + certificatePath = workDir.resolve("cert.pem"); + generateSelfSignedCertificate(keyPath, certificatePath); + + TokenHandler oauthTokenHandler = new TokenHandler(OAUTH_TOKEN_RESPONSE); + httpServer = HttpServer.create(new InetSocketAddress(0), 0); + httpServer.createContext("/token", oauthTokenHandler); + httpServer.start(); + + SSLContext sslContext = buildSslContext(keyPath, certificatePath); + httpsServer = HttpsServer.create(new InetSocketAddress(0), 0); + httpsServer.setHttpsConfigurator(new com.sun.net.httpserver.HttpsConfigurator(sslContext)); + httpsServer.createContext("/v1/token", new TokenHandler(STS_TOKEN_RESPONSE)); + httpsServer.start(); + } + + /** Port forwarded by {@link GcsStsProxyContainer} ({@code sts.googleapis.com:443}). */ + public int getStsPort() { + return httpsServer.getAddress().getPort(); + } + + public String getTokenUri() { + return String.format("http://%s:%d/token";, HOST_GATEWAY, httpServer.getAddress().getPort()); + } + + /** PEM certificate to import into the Gravitino JVM truststore. */ + public Path getCertificatePath() { + return certificatePath; + } + + @Override + public void close() { + if (httpServer != null) { + httpServer.stop(0); + httpServer = null; + } + if (httpsServer != null) { + httpsServer.stop(0); + httpsServer = null; + } + if (workDir != null) { + deleteQuietly(workDir); + workDir = null; + certificatePath = null; + } + } + + private static SSLContext buildSslContext(Path keyPath, Path certPath) throws Exception { + Path pkcs12 = keyPath.getParent().resolve("keystore.p12"); + ProcessBuilder pb = new ProcessBuilder( + "openssl", "pkcs12", "-export", + "-inkey", keyPath.toString(), + "-in", certPath.toString(), + "-out", pkcs12.toString(), + "-passout", "pass:changeit", + "-name", STS_CN); + runOrThrow(pb); + KeyStore keyStore = KeyStore.getInstance("PKCS12"); + try (InputStream in = Files.newInputStream(pkcs12)) { + keyStore.load(in, "changeit".toCharArray()); Review Comment: ## SonarCloud / Credentials should not be hard-coded <!--SONAR_ISSUE_KEY:AaADnYk4k1xzxvxQYwvn-->Revoke and change this password, as it is compromised. <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_hive&issues=AaADnYk4k1xzxvxQYwvn&open=AaADnYk4k1xzxvxQYwvn&pullRequest=6655";>SonarQube Cloud</a></p> [Show more details](https://github.com/apache/hive/security/code-scanning/449) ########## itests/util/src/main/java/org/apache/hadoop/hive/cli/GcsOAuthTokenMock.java: ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.cli; + +import com.sun.net.httpserver.HttpExchange; +import com.sun.net.httpserver.HttpHandler; +import com.sun.net.httpserver.HttpServer; +import com.sun.net.httpserver.HttpsServer; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.net.InetSocketAddress; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.Path; +import java.security.KeyStore; +import java.util.concurrent.TimeUnit; +import javax.net.ssl.KeyManagerFactory; +import javax.net.ssl.SSLContext; + +/** + * Minimal Google OAuth2/STS token endpoint mock for Gravitino {@code gcs-token} credential vending. + * + * <p>Runs two endpoints on separate ports: + * <ul> + * <li>Plain HTTP {@code POST /token} for service-account {@code token_uri}</li> + * <li>HTTPS {@code POST /v1/token} with {@code CN=sts.googleapis.com} for Google STS</li> + * </ul> + * The test wires {@link GcsStsProxyContainer} to forward {@code sts.googleapis.com:443} to the + * HTTPS port, and imports {@link #getCertificatePath()} into the Gravitino container truststore. + */ +public final class GcsOAuthTokenMock implements AutoCloseable { + + /** Token value returned to Gravitino; fake-gcs-server does not validate it. */ + public static final String ACCESS_TOKEN = "gcs-test-access-token"; + private static final String STS_CN = "sts.googleapis.com"; + static final String HOST_GATEWAY = GcsFakeServerContainers.HOST_GATEWAY; + + private static final byte[] OAUTH_TOKEN_RESPONSE = String.format( + "{\"access_token\":\"%s\",\"expires_in\":3600,\"token_type\":\"Bearer\"}", + ACCESS_TOKEN).getBytes(StandardCharsets.UTF_8); + + private static final byte[] STS_TOKEN_RESPONSE = String.format( + "{\"access_token\":\"%s\",\"issued_token_type\":\"urn:ietf:params:oauth:token-type:access_token\"," + + "\"token_type\":\"Bearer\",\"expires_in\":3600}", + ACCESS_TOKEN).getBytes(StandardCharsets.UTF_8); + + private HttpServer httpServer; + private HttpsServer httpsServer; + private Path certificatePath; + private Path workDir; + + /** Starts HTTP and HTTPS servers on ephemeral ports. */ + public void start() throws Exception { + workDir = Files.createTempDirectory("gcs-oauth-mock-"); + Path keyPath = workDir.resolve("key.pem"); + certificatePath = workDir.resolve("cert.pem"); + generateSelfSignedCertificate(keyPath, certificatePath); + + TokenHandler oauthTokenHandler = new TokenHandler(OAUTH_TOKEN_RESPONSE); + httpServer = HttpServer.create(new InetSocketAddress(0), 0); + httpServer.createContext("/token", oauthTokenHandler); + httpServer.start(); + + SSLContext sslContext = buildSslContext(keyPath, certificatePath); + httpsServer = HttpsServer.create(new InetSocketAddress(0), 0); + httpsServer.setHttpsConfigurator(new com.sun.net.httpserver.HttpsConfigurator(sslContext)); + httpsServer.createContext("/v1/token", new TokenHandler(STS_TOKEN_RESPONSE)); + httpsServer.start(); + } + + /** Port forwarded by {@link GcsStsProxyContainer} ({@code sts.googleapis.com:443}). */ + public int getStsPort() { + return httpsServer.getAddress().getPort(); + } + + public String getTokenUri() { + return String.format("http://%s:%d/token";, HOST_GATEWAY, httpServer.getAddress().getPort()); + } + + /** PEM certificate to import into the Gravitino JVM truststore. */ + public Path getCertificatePath() { + return certificatePath; + } + + @Override + public void close() { + if (httpServer != null) { + httpServer.stop(0); + httpServer = null; + } + if (httpsServer != null) { + httpsServer.stop(0); + httpsServer = null; + } + if (workDir != null) { + deleteQuietly(workDir); + workDir = null; + certificatePath = null; + } + } + + private static SSLContext buildSslContext(Path keyPath, Path certPath) throws Exception { + Path pkcs12 = keyPath.getParent().resolve("keystore.p12"); + ProcessBuilder pb = new ProcessBuilder( + "openssl", "pkcs12", "-export", + "-inkey", keyPath.toString(), + "-in", certPath.toString(), + "-out", pkcs12.toString(), + "-passout", "pass:changeit", + "-name", STS_CN); + runOrThrow(pb); + KeyStore keyStore = KeyStore.getInstance("PKCS12"); + try (InputStream in = Files.newInputStream(pkcs12)) { + keyStore.load(in, "changeit".toCharArray()); + } + KeyManagerFactory kmf = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm()); + kmf.init(keyStore, "changeit".toCharArray()); + SSLContext sslContext = SSLContext.getInstance("TLS"); + sslContext.init(kmf.getKeyManagers(), null, null); + return sslContext; + } + + private static void generateSelfSignedCertificate(Path keyPath, Path certPath) throws Exception { + ProcessBuilder pb = new ProcessBuilder( + "openssl", "req", "-x509", "-newkey", "rsa:2048", Review Comment: ## SonarCloud / OS commands should not rely on PATH resolution <!--SONAR_ISSUE_KEY:AaADnYk4k1xzxvxQYwvp-->Make sure the "PATH" variable only contains fixed, unwriteable directories. <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_hive&issues=AaADnYk4k1xzxvxQYwvp&open=AaADnYk4k1xzxvxQYwvp&pullRequest=6655";>SonarQube Cloud</a></p> [Show more details](https://github.com/apache/hive/security/code-scanning/453) ########## itests/util/src/main/java/org/apache/hadoop/hive/cli/GcsOAuthTokenMock.java: ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.cli; + +import com.sun.net.httpserver.HttpExchange; +import com.sun.net.httpserver.HttpHandler; +import com.sun.net.httpserver.HttpServer; +import com.sun.net.httpserver.HttpsServer; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.net.InetSocketAddress; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.Path; +import java.security.KeyStore; +import java.util.concurrent.TimeUnit; +import javax.net.ssl.KeyManagerFactory; +import javax.net.ssl.SSLContext; + +/** + * Minimal Google OAuth2/STS token endpoint mock for Gravitino {@code gcs-token} credential vending. + * + * <p>Runs two endpoints on separate ports: + * <ul> + * <li>Plain HTTP {@code POST /token} for service-account {@code token_uri}</li> + * <li>HTTPS {@code POST /v1/token} with {@code CN=sts.googleapis.com} for Google STS</li> + * </ul> + * The test wires {@link GcsStsProxyContainer} to forward {@code sts.googleapis.com:443} to the + * HTTPS port, and imports {@link #getCertificatePath()} into the Gravitino container truststore. + */ +public final class GcsOAuthTokenMock implements AutoCloseable { + + /** Token value returned to Gravitino; fake-gcs-server does not validate it. */ + public static final String ACCESS_TOKEN = "gcs-test-access-token"; + private static final String STS_CN = "sts.googleapis.com"; + static final String HOST_GATEWAY = GcsFakeServerContainers.HOST_GATEWAY; + + private static final byte[] OAUTH_TOKEN_RESPONSE = String.format( + "{\"access_token\":\"%s\",\"expires_in\":3600,\"token_type\":\"Bearer\"}", + ACCESS_TOKEN).getBytes(StandardCharsets.UTF_8); + + private static final byte[] STS_TOKEN_RESPONSE = String.format( + "{\"access_token\":\"%s\",\"issued_token_type\":\"urn:ietf:params:oauth:token-type:access_token\"," + + "\"token_type\":\"Bearer\",\"expires_in\":3600}", + ACCESS_TOKEN).getBytes(StandardCharsets.UTF_8); + + private HttpServer httpServer; + private HttpsServer httpsServer; + private Path certificatePath; + private Path workDir; + + /** Starts HTTP and HTTPS servers on ephemeral ports. */ + public void start() throws Exception { + workDir = Files.createTempDirectory("gcs-oauth-mock-"); + Path keyPath = workDir.resolve("key.pem"); + certificatePath = workDir.resolve("cert.pem"); + generateSelfSignedCertificate(keyPath, certificatePath); + + TokenHandler oauthTokenHandler = new TokenHandler(OAUTH_TOKEN_RESPONSE); + httpServer = HttpServer.create(new InetSocketAddress(0), 0); + httpServer.createContext("/token", oauthTokenHandler); + httpServer.start(); + + SSLContext sslContext = buildSslContext(keyPath, certificatePath); + httpsServer = HttpsServer.create(new InetSocketAddress(0), 0); + httpsServer.setHttpsConfigurator(new com.sun.net.httpserver.HttpsConfigurator(sslContext)); + httpsServer.createContext("/v1/token", new TokenHandler(STS_TOKEN_RESPONSE)); + httpsServer.start(); + } + + /** Port forwarded by {@link GcsStsProxyContainer} ({@code sts.googleapis.com:443}). */ + public int getStsPort() { + return httpsServer.getAddress().getPort(); + } + + public String getTokenUri() { + return String.format("http://%s:%d/token";, HOST_GATEWAY, httpServer.getAddress().getPort()); + } + + /** PEM certificate to import into the Gravitino JVM truststore. */ + public Path getCertificatePath() { + return certificatePath; + } + + @Override + public void close() { + if (httpServer != null) { + httpServer.stop(0); + httpServer = null; + } + if (httpsServer != null) { + httpsServer.stop(0); + httpsServer = null; + } + if (workDir != null) { + deleteQuietly(workDir); + workDir = null; + certificatePath = null; + } + } + + private static SSLContext buildSslContext(Path keyPath, Path certPath) throws Exception { + Path pkcs12 = keyPath.getParent().resolve("keystore.p12"); + ProcessBuilder pb = new ProcessBuilder( + "openssl", "pkcs12", "-export", Review Comment: ## SonarCloud / OS commands should not rely on PATH resolution <!--SONAR_ISSUE_KEY:AaADnYk4k1xzxvxQYwvm-->Make sure the "PATH" variable only contains fixed, unwriteable directories. <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_hive&issues=AaADnYk4k1xzxvxQYwvm&open=AaADnYk4k1xzxvxQYwvm&pullRequest=6655";>SonarQube Cloud</a></p> [Show more details](https://github.com/apache/hive/security/code-scanning/452) ########## itests/util/src/main/java/org/apache/hadoop/hive/cli/GcsOAuthTokenMock.java: ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.cli; + +import com.sun.net.httpserver.HttpExchange; +import com.sun.net.httpserver.HttpHandler; +import com.sun.net.httpserver.HttpServer; +import com.sun.net.httpserver.HttpsServer; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.net.InetSocketAddress; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.Path; +import java.security.KeyStore; +import java.util.concurrent.TimeUnit; +import javax.net.ssl.KeyManagerFactory; +import javax.net.ssl.SSLContext; + +/** + * Minimal Google OAuth2/STS token endpoint mock for Gravitino {@code gcs-token} credential vending. + * + * <p>Runs two endpoints on separate ports: + * <ul> + * <li>Plain HTTP {@code POST /token} for service-account {@code token_uri}</li> + * <li>HTTPS {@code POST /v1/token} with {@code CN=sts.googleapis.com} for Google STS</li> + * </ul> + * The test wires {@link GcsStsProxyContainer} to forward {@code sts.googleapis.com:443} to the + * HTTPS port, and imports {@link #getCertificatePath()} into the Gravitino container truststore. + */ +public final class GcsOAuthTokenMock implements AutoCloseable { + + /** Token value returned to Gravitino; fake-gcs-server does not validate it. */ + public static final String ACCESS_TOKEN = "gcs-test-access-token"; + private static final String STS_CN = "sts.googleapis.com"; + static final String HOST_GATEWAY = GcsFakeServerContainers.HOST_GATEWAY; + + private static final byte[] OAUTH_TOKEN_RESPONSE = String.format( + "{\"access_token\":\"%s\",\"expires_in\":3600,\"token_type\":\"Bearer\"}", + ACCESS_TOKEN).getBytes(StandardCharsets.UTF_8); + + private static final byte[] STS_TOKEN_RESPONSE = String.format( + "{\"access_token\":\"%s\",\"issued_token_type\":\"urn:ietf:params:oauth:token-type:access_token\"," + + "\"token_type\":\"Bearer\",\"expires_in\":3600}", + ACCESS_TOKEN).getBytes(StandardCharsets.UTF_8); + + private HttpServer httpServer; + private HttpsServer httpsServer; + private Path certificatePath; + private Path workDir; + + /** Starts HTTP and HTTPS servers on ephemeral ports. */ + public void start() throws Exception { + workDir = Files.createTempDirectory("gcs-oauth-mock-"); + Path keyPath = workDir.resolve("key.pem"); + certificatePath = workDir.resolve("cert.pem"); + generateSelfSignedCertificate(keyPath, certificatePath); + + TokenHandler oauthTokenHandler = new TokenHandler(OAUTH_TOKEN_RESPONSE); + httpServer = HttpServer.create(new InetSocketAddress(0), 0); + httpServer.createContext("/token", oauthTokenHandler); + httpServer.start(); + + SSLContext sslContext = buildSslContext(keyPath, certificatePath); + httpsServer = HttpsServer.create(new InetSocketAddress(0), 0); + httpsServer.setHttpsConfigurator(new com.sun.net.httpserver.HttpsConfigurator(sslContext)); + httpsServer.createContext("/v1/token", new TokenHandler(STS_TOKEN_RESPONSE)); + httpsServer.start(); + } + + /** Port forwarded by {@link GcsStsProxyContainer} ({@code sts.googleapis.com:443}). */ + public int getStsPort() { + return httpsServer.getAddress().getPort(); + } + + public String getTokenUri() { + return String.format("http://%s:%d/token";, HOST_GATEWAY, httpServer.getAddress().getPort()); + } + + /** PEM certificate to import into the Gravitino JVM truststore. */ + public Path getCertificatePath() { + return certificatePath; + } + + @Override + public void close() { + if (httpServer != null) { + httpServer.stop(0); + httpServer = null; + } + if (httpsServer != null) { + httpsServer.stop(0); + httpsServer = null; + } + if (workDir != null) { + deleteQuietly(workDir); + workDir = null; + certificatePath = null; + } + } + + private static SSLContext buildSslContext(Path keyPath, Path certPath) throws Exception { + Path pkcs12 = keyPath.getParent().resolve("keystore.p12"); + ProcessBuilder pb = new ProcessBuilder( + "openssl", "pkcs12", "-export", + "-inkey", keyPath.toString(), + "-in", certPath.toString(), + "-out", pkcs12.toString(), + "-passout", "pass:changeit", + "-name", STS_CN); + runOrThrow(pb); + KeyStore keyStore = KeyStore.getInstance("PKCS12"); + try (InputStream in = Files.newInputStream(pkcs12)) { + keyStore.load(in, "changeit".toCharArray()); + } + KeyManagerFactory kmf = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm()); + kmf.init(keyStore, "changeit".toCharArray()); Review Comment: ## SonarCloud / Credentials should not be hard-coded <!--SONAR_ISSUE_KEY:AaADnYk4k1xzxvxQYwvo-->Revoke and change this password, as it is compromised. <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_hive&issues=AaADnYk4k1xzxvxQYwvo&open=AaADnYk4k1xzxvxQYwvo&pullRequest=6655";>SonarQube Cloud</a></p> [Show more details](https://github.com/apache/hive/security/code-scanning/450) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
