Aggarwal-Raghav commented on code in PR #6709:
URL: https://github.com/apache/hive/pull/6709#discussion_r3815530114
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MergeFileRecordProcessor.java:
##########
@@ -94,20 +90,10 @@ void init(
.initialize();
}
- String queryId = HiveConf.getVar(jconf, HiveConf.ConfVars.HIVE_QUERY_ID);
- cache = ObjectCacheFactory.getCache(jconf, queryId, true);
-
try {
execContext.setJc(jconf);
- cacheKey = MAP_PLAN_KEY;
-
- MapWork mapWork = (MapWork) cache.retrieve(cacheKey, new
Callable<Object>() {
- @Override
- public Object call() {
- return Utilities.getMapWork(jconf);
- }
- });
+ MapWork mapWork = (MapWork) planCache.retrieve(MAP_PLAN_KEY,
(Callable<Object>) () -> Utilities.getMapWork(jconf));
Review Comment:
nit: Extra casting ? in other hunks, the Callable / MapWork is not present
in retrieve().
```java
MapWork mapWork = planCache.retrieve(MAP_PLAN_KEY, () ->
Utilities.getMapWork(jconf));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
