soumyakanti3578 commented on code in PR #6636: URL: https://github.com/apache/hive/pull/6636#discussion_r3834022188
########## standalone-metastore/metastore-server/src/main/sql/mysql/rebuild-indexes.mysql.sql: ########## @@ -0,0 +1,169 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE file distributed with +-- this work for additional information regarding copyright ownership. +-- The ASF licenses this file to you under the Apache License, Version 2.0 +-- (the "License"); you may not use this file except in compliance with +-- the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, software +-- distributed under the License is distributed on an "AS IS" BASIS, +-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +-- See the License for the specific language governing permissions and +-- limitations under the License. + + +-- Rebuilds all HMS indexes on MySQL using ALTER TABLE for atomicity. + +ALTER TABLE `BUCKETING_COLS` DROP INDEX `BUCKETING_COLS_N49`, ADD INDEX `BUCKETING_COLS_N49` (`SD_ID`); Review Comment: Yes, these rebuild-indexes files have to be maintained manually. I think this is a good compromise between **a)** reading all the indexes from DB internal tables/views, then identifying the HMS indexes, and then rebuilding them. **b)** using (more) regex for parsing the schema files to find the indexes and then rebuilding them. The first method adds a lot of code for a relatively simple feature, increasing maintainability, and the second method is just too brittle and buggy. `TestRebuildIndexesScriptConsistency` has tests to help with the scenario you are describing: https://github.com/apache/hive/pull/6636#discussion_r3686723864 and I am open to more ideas and suggestions :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
