kasakrisz commented on code in PR #6700:
URL: https://github.com/apache/hive/pull/6700#discussion_r3860329824
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnAccessInfo.java:
##########
@@ -92,6 +92,18 @@ public Map<String, List<String>>
getTableToColumnAllAccessMap() {
return mapping;
}
+ /**
+ * Merge column accesses from another ColumnAccessInfo into this one.
+ */
+ public void merge(ColumnAccessInfo other) {
+ if (other == null) {
+ return;
+ }
+ for (Map.Entry<String, ColumnAccess> entry :
other.tableToColumnAccessMap.entries()) {
+ tableToColumnAccessMap.put(entry.getKey(), entry.getValue());
+ }
Review Comment:
how about
```
tableToColumnAccessMap.putAll(other.tableToColumnAccessMap)
```
?
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnAccessAnalyzer.java:
##########
@@ -34,7 +34,8 @@ public ColumnAccessAnalyzer(ParseContext pactx) {
pGraphContext = pactx;
}
- public ColumnAccessInfo analyzeColumnAccess(ColumnAccessInfo
columnAccessInfo) throws SemanticException {
+ public ColumnAccessInfo analyzeColumnAccess(SemanticAnalyzer analyzer)
throws SemanticException {
+ ColumnAccessInfo columnAccessInfo = analyzer.getColumnAccessInfo();
Review Comment:
I missed that. Thanks for pointing it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
