Aggarwal-Raghav commented on PR #6728:
URL: https://github.com/apache/hive/pull/6728#issuecomment-5456459012

   @difin , this is my understanding of the patch. Can you please correct me if 
I missed anything?
   **Possible Limitation:**
   After this PR, user can no longer manually target old partition specs using 
a WHERE filter. Users will now have to rely on the background auto-compactor 
(below ROW 18) or run a full-table compaction without a WHERE clause correct?
   
   **Testing:**
   I checked the behaviour explained in description locally and can confirm it 
works exactly as described.
   
   Before this patch, running `ALTER TABLE tbl1 COMPACT 'MAJOR' AND WAIT WHERE 
company_id = 100` on an evolved Iceberg table would correctly enqueue the new 
partitions, but also blindly enqueue a `---` compaction (ROW 19), confirming a 
rewrite of all old-spec data.
   
   ```
       | compactionid | tabname | partname                 | type  | state     
| initiatorid |
       | 16           | tbl1    | company_id=100/dept_id=2 | MAJOR | refused   
| manual      |
       | 17           | tbl1    | company_id=100/dept_id=1 | MAJOR | succeeded 
| manual      |
       | 18           | tbl1    | ---                      | MAJOR | succeeded 
| 884 (auto)  |
       | 19           | tbl1    | ---                      | MAJOR | refused   
| manual      |
   ```
   
   After this PR, The `---` row with manual entry is entirely GONE!. I think 
this is expected fix!
   ```
       | 23 | test | tbl1 | company_id=100/dept_id=1 | MAJOR | succeeded | 
manual |
       | 22 | test | tbl1 | company_id=100/dept_id=2 | MAJOR | refused   | 
manual |
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to