deniskuzZ commented on code in PR #6701:
URL: https://github.com/apache/hive/pull/6701#discussion_r3917168972
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java:
##########
@@ -640,6 +641,7 @@ protected void initializeOp(Configuration hconf) throws
HiveException {
jc = new JobConf(hconf);
setWriteOperation(jc, getConf().getTableInfo().getTableName(),
getConf().getWriteOperation());
+ setStatementOperation(jc, getConf().getTableInfo().getTableName(),
getConf().getStatementOperation());
Review Comment:
@Aggarwal-Raghav FYI, there is also queryState.`getHiveOperation()`.
Needs testing if ctx.getOperation() and queryState.getHiveOperation() match,
if so why do we need both??
@kasakrisz would it be a better naming: hiveOperation ?
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java:
##########
@@ -640,6 +641,7 @@ protected void initializeOp(Configuration hconf) throws
HiveException {
jc = new JobConf(hconf);
setWriteOperation(jc, getConf().getTableInfo().getTableName(),
getConf().getWriteOperation());
+ setStatementOperation(jc, getConf().getTableInfo().getTableName(),
getConf().getStatementOperation());
Review Comment:
@Aggarwal-Raghav FYI, there is also queryState.`getHiveOperation()`.
Needs testing if ctx.getOperation() and queryState.getHiveOperation() match,
if so why do we need both??
@kasakrisz would it be a better naming: `hiveOperation` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
