abstractdog commented on code in PR #6747:
URL: https://github.com/apache/hive/pull/6747#discussion_r3925938057
##########
serde/src/java/org/apache/hadoop/hive/serde2/lazy/fast/LazySimpleDeserializeRead.java:
##########
@@ -432,20 +496,54 @@ private void topLevelParse() {
* Optimize the loops by pulling special end cases and global decisions
like isEscaped out!
*/
if (!isEscaped) {
- while (fieldByteEnd < end) {
- if (bytes[fieldByteEnd] == separator) {
+ if (fieldDelimMulti == null) {
Review Comment:
ack, this method was already chaos without this refactor
I believe, with this refactor, we may lose some JIT inlining, however,
honestly, the LLM realized very well that redefining class fields as final
local variables helps JIT make sure that these variables are not changed while
working with the hot loop (okay, this was already part of the code, it just
follows the pattern, correctly)
I also took the opportunity to cover all cases with new methods in
`TestLazySimpleDeserializeRead`, those also justifies removing the qtests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
