deniskuzZ commented on code in PR #6747:
URL: https://github.com/apache/hive/pull/6747#discussion_r3940822632
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VectorDeserializeOrcWriter.java:
##########
@@ -102,33 +104,55 @@ public static EncodingWriter create(InputFormat<?, ?>
sourceIf, Deserializer ser
Configuration daemonConf, Configuration jobConf, Path splitPath,
StructObjectInspector sourceOi,
List<Integer> sourceIncludes, boolean[] cacheIncludes, int allocSize,
ExecutorService encodeExecutor)
throws IOException {
- // Vector SerDe can be disabled both on client and server side.
+ /*
+ * Vector SerDe can be disabled both on client and server side.
+ * MultiDelimitSerDe is accepted alongside LazySimpleSerDe: it's the same
+ * text-row shape, only its top-level FIELD_DELIM can span multiple bytes.
+ * The reader (LazySimpleDeserializeRead) picks the multi-byte scanner
+ * when LazySerDeParameters.setFieldDelimMulti has been called below —
+ * otherwise the specialized single-byte hot loop runs unchanged.
+ */
+ final boolean isTextInput = sourceIf instanceof TextInputFormat;
Review Comment:
wdyt if we keep inline instance but refactor to
````
final boolean vectorSerdeEnabled =
HiveConf.getBoolVar(daemonConf,
ConfVars.LLAP_IO_ENCODE_VECTOR_SERDE_ENABLED)
&& HiveConf.getBoolVar(jobConf,
ConfVars.LLAP_IO_ENCODE_VECTOR_SERDE_ENABLED);
final boolean isMultiDelim = serDe instanceof MultiDelimitSerDe;
if (!vectorSerdeEnabled
|| !(sourceIf instanceof TextInputFormat)
|| (!(serDe instanceof LazySimpleSerDe) && !isMultiDelim)) {
return new DeserializerOrcWriter(serDe, sourceOi, allocSize);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
