deniskuzZ commented on code in PR #6748:
URL: https://github.com/apache/hive/pull/6748#discussion_r3940996545


##########
beeline/pom.xml:
##########
@@ -133,12 +129,47 @@
           <groupId>log4j</groupId>
           <artifactId>log4j</artifactId>
         </exclusion>
+        <!-- kerby/kerberos auth chain pulled in transitively via hadoop-auth; 
beeline
+             does not exercise hadoop-common's Kerberos/UGI code paths -->
+        <exclusion>

Review Comment:
   do we still package optional deps?
   ````
   <artifactId>hadoop-common</artifactId>
   <optional>true</optional>
   ````



##########
beeline/pom.xml:
##########
@@ -133,12 +129,47 @@
           <groupId>log4j</groupId>
           <artifactId>log4j</artifactId>
         </exclusion>
+        <!-- kerby/kerberos auth chain pulled in transitively via hadoop-auth; 
beeline
+             does not exercise hadoop-common's Kerberos/UGI code paths -->
+        <exclusion>

Review Comment:
   do we package optional deps?
   ````
   <artifactId>hadoop-common</artifactId>
   <optional>true</optional>
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to