ramitg254 commented on code in PR #6752:
URL: https://github.com/apache/hive/pull/6752#discussion_r3943420779
##########
ql/src/test/queries/clientpositive/cbo_windowing.q:
##########
@@ -10,6 +10,11 @@ set hive.auto.convert.join=false;
-- 9. Test Windowing Functions
-- SORT_QUERY_RESULTS
+-- Vector PTF does not buffer PARTITION BY columns (constant within a
partition). When a partition
Review Comment:
I was thinking it should be evaluator specific in vectorised mode like here
I ran into this in case of sum which should be computed for partition column
not via buffered column values but via (constant partition column value* no. of
rows in the partition) but since currently it only works via buffered column
approach where we don't have partition column so index mapping is wrong in that
case,
I think it would need some investigation regarding which evaluators should
support it or not and should be made evaluator specific rather than a generic
exception thrown?
I didn't created a ticket yet for it, if you think that makes then I'll
create one and add the todo here, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
