abstractdog commented on code in PR #6751:
URL: https://github.com/apache/hive/pull/6751#discussion_r3954934939
##########
pom.xml:
##########
@@ -1903,6 +1903,8 @@
<!-- required by a few tests to find the derby jar -->
<derby.version>${derby.version}</derby.version>
<derby.stream.error.file>${test.tmp.dir}/derby.log</derby.stream.error.file>
+ <!-- required by TestBeelineArgParsing to find the postgresql jar
-->
Review Comment:
nit: could this be changed to "<!-- required by tests to find the postgresql
jar -->"
sooner or later, other tests are also encouraged to follow this pattern,
`TestBeelineArgParsing` won't be the only only one, otherwise this looks good
to me
##########
pom.xml:
##########
@@ -1903,6 +1903,8 @@
<!-- required by a few tests to find the derby jar -->
<derby.version>${derby.version}</derby.version>
<derby.stream.error.file>${test.tmp.dir}/derby.log</derby.stream.error.file>
+ <!-- required by TestBeelineArgParsing to find the postgresql jar
-->
Review Comment:
nit: could this be changed to `<!-- required by tests to find the postgresql
jar -->`
sooner or later, other tests are also encouraged to follow this pattern,
`TestBeelineArgParsing` won't be the only only one, otherwise this looks good
to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
