tanishq-chugh commented on code in PR #6744:
URL: https://github.com/apache/hive/pull/6744#discussion_r3955143590
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/filtercontext/DatabaseFilterContext.java:
##########
@@ -89,7 +89,7 @@ private List<HivePrivilegeObject> getInputHObjs() {
if (db != null) {
ret.add(getHivePrivilegeObject(db));
} else {
- HivePrivilegeObject hivePrivilegeObject = new
HivePrivilegeObject(type, dbName);
+ HivePrivilegeObject hivePrivilegeObject = new
HivePrivilegeObject(type, catName, dbName, dbName);
Review Comment:
@Aggarwal-Raghav
I kept the objectName same as dbName here to keep it consistent with
`AuthorizationMetaStoreFilterHook` where the
[HivePrivilegeObjectUtils](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObjectUtils.java#L41-L48)
utility method constructs the HivePrivilege Objects in the same shape
(thinking of re-using this utility method here). This would keep the objects
being referred by authorization manager / external plugin consistent across the
two filter hook implementations.
However, i have found a couple of more issues with `HiveMetaStoreAuthorizer`
that i plan to fix as part of this same PR. Changing it to draft for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
