kasakrisz commented on code in PR #6701:
URL: https://github.com/apache/hive/pull/6701#discussion_r3979063160
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java:
##########
@@ -112,6 +112,7 @@ public enum DPSortState {
private Path destPath;
private boolean isHiveServerQuery;
private boolean isMerge;
+ private boolean isCopyOnWrite = false;
Review Comment:
nit.
```
field: boolean copyOnWrite;
getter: isCopyOnWrite()
setter: setCopyOnWrite(boolean)
```
See other boolean fields
https://github.com/apache/hive/blob/2be30b71b6a112edde13d2ea1a11144b5abf1c04/ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java#L65-L67
https://github.com/apache/hive/blob/2be30b71b6a112edde13d2ea1a11144b5abf1c04/ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java#L352-L372
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/WriterBuilder.java:
##########
@@ -73,6 +73,7 @@ public class WriterBuilder {
private TaskAttemptID attemptID;
private String queryId;
private Operation operation;
+ private final boolean isCopyOnWrite;
Review Comment:
nit: AFAIK the boolean field name doesn't need the `is` prefix. The getter
has it.
```
field: boolean copyOnWrite;
getter: isCopyOnWrite()
setter: setCopyOnWrite(boolean)
```
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -96,4 +97,16 @@ public static boolean
isMergeTaskEnabled(UnaryOperator<String> ops, String table
String operation = ops.apply(MERGE_TASK_ENABLED + tableName);
return Boolean.parseBoolean(operation);
}
+
+ public static void setIsCopyOnWrite(Configuration conf, String tableName,
boolean isCopyOnWrite) {
Review Comment:
nit.: `setCopyOnWrite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
