Akanksha-kedia commented on PR #6760: URL: https://github.com/apache/hive/pull/6760#issuecomment-5634154020
Found and fixed another instance of the same root cause, and confirmed the `TestHBaseSerDe` diff floating around isn't actually needed — details below. **itests/qtest — `TestMiniHiveKafkaCliDriver` (`kafka_storage_handler.q`)**: `QTestMiniClusters#getAvroRows()` calls `new SpecificDatumWriter<>(Wikipedia.getClassSchema())`, which goes through the identical `SpecificData.getForSchema()` → `getClass()` path already fixed for `SimpleRecord` in `AvroBytesConverterTest` — same `SecurityException`, this time for `org.apache.hive.kafka.Wikipedia`. Fixed the same way: `maven-surefire-plugin` `systemPropertyVariables` in `itests/qtest/pom.xml` (JVM-startup property, not `@BeforeClass` — already shown unreliable for this exact failure mode earlier in this thread). Pushed. Caveat: I could not run this specific test end-to-end locally — building the full `itests` profile reactor here pulls in `hive-hcatalog`, whose legacy test deps (`commons-httpclient:3.1`, `jetty:6.1.26`) are blocked by a local network policy unrelated to this change. Confident in the fix by code-path analysis and by direct analogy to the already-reproduced `SimpleRecord` case, but flagging that I'm relying on Jenkins for the actual green check here rather than a local run. **`TestHBaseSerDe`**: ran it unmodified against avro 1.12.2 — **17/17 pass, no `SecurityException`, no trust property needed.** It uses `new SpecificDatumWriter<Employee>(Employee.class)` (class-direct constructor), which never goes through the schema-name→class resolution path that `ClassSecurityValidator` guards. So the `@BeforeClass`/`SERIALIZABLE_PACKAGES` change proposed for it isn't fixing a real problem, and carries the same reliability risk we already ruled out for `AvroBytesConverterTest`. Didn't apply it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
