tanishq-chugh commented on code in PR #6754:
URL: https://github.com/apache/hive/pull/6754#discussion_r4000512228
##########
ql/pom.xml:
##########
@@ -110,6 +110,16 @@
<artifactId>commons-configuration</artifactId>
<version>${commons-configuration.version}</version>
</dependency>
+ <!-- Staged for a future migration off the unmaintained
commons-configuration 1.x line.
+ Not wired into any call site yet: the only two consumers
(AtlasRestClientBuilder and
+ TestAtlasDumpTask) feed
org.apache.atlas.ApplicationProperties.set(Configuration), and
+ Atlas 2.4.0's API (pinned above) hardcodes commons-configuration
1.x's Configuration type.
+ Migrating those call sites needs an Atlas client upgrade first, which
is out of scope here. -->
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-configuration2</artifactId>
+ <version>${commons-configuration2.version}</version>
+ </dependency>
Review Comment:
Hi @Akanksha-kedia
If we are not able to migrate/upgrade to commons-configuration 2, why are we
adding it alongside existing v1 ? What is the need here?
Also, the Test Failures -
[precommit-PR-6754](https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-6754/2/tests)
seem to be related to your change itself and not broken.
The errors are related to commons-configuration:
```
Stacktrace
java.lang.NoClassDefFoundError: Could not initialize class
org.apache.commons.configuration2.io.FileLocatorUtils
at
org.apache.commons.configuration2.io.FileHandler.emptyFileLocator(FileHandler.java:215)
at
org.apache.commons.configuration2.io.FileHandler.<init>(FileHandler.java:267)
at
org.apache.hadoop.metrics2.impl.MetricsConfig.loadFirst(MetricsConfig.java:118)
at
org.apache.hadoop.metrics2.impl.MetricsConfig.create(MetricsConfig.java:99)
at
org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:481)
at
org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)
at
org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)
at
org.apache.iceberg.mr.hive.test.utils.HiveIcebergStorageHandlerTestUtils.init(HiveIcebergStorageHandlerTestUtils.java:148)
at
org.apache.iceberg.mr.hive.test.utils.HiveIcebergStorageHandlerTestUtils.init(HiveIcebergStorageHandlerTestUtils.java:132)
at
org.apache.iceberg.mr.hive.HiveIcebergStorageHandlerWithEngineBase.before(HiveIcebergStorageHandlerWithEngineBase.java:245)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.ExceptionInInitializerError: Exception
java.lang.NoSuchMethodError: 'java.lang.Object
org.apache.commons.configuration2.io.HomeDirectoryLocationStrategy$Builder.getUnchecked()'
[in thread "Time-limited test"]
at
org.apache.commons.configuration2.io.FileLocatorUtils.newDefaultLocationStrategy(FileLocatorUtils.java:500)
at
org.apache.commons.configuration2.io.FileLocatorUtils.<clinit>(FileLocatorUtils.java:77)
... 13 more
```
Just FYI, the last precommit run on top of master was also green:
[hive-precommit-3077](https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/master/3077/pipeline)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
