Aggarwal-Raghav commented on code in PR #6685:
URL: https://github.com/apache/hive/pull/6685#discussion_r4007683241
##########
ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java:
##########
@@ -1114,19 +1114,19 @@ public void testQuotedIdentifier() throws Exception {
"`d?*de e` decimal(5,2)," +
"vc varchar(128)) clustered by (i) into 2 buckets stored as orc
TBLPROPERTIES ('transactional'='true')");
runStatementOnDriver("create table " + src + "(gh int, j decimal(5,2), k
varchar(128))");
- runStatementOnDriver("merge into " + target + " as `d/8` using " + src + "
as `a/b` on i=gh " +
+ runStatementOnDriver("merge into " + target + " as `d/8` using " + src + "
as `a/b` on `d/8`.i=`a/b`.gh " +
"\nwhen matched and i > 5 then delete " +
"\nwhen matched then update set vc='blah' " +
"\nwhen not matched then insert values(1,2.1,'baz')");
- runStatementOnDriver("merge into " + target + " as `d/8` using " + src + "
as `a/b` on i=gh " +
+ runStatementOnDriver("merge into " + target + " as `d/8` using " + src + "
as `a/b` on `d/8`.i=`a/b`.gh " +
Review Comment:
This seems to be a breaking change! For acid table, users will have to
change their query scripts. Maybe we can enforce the check only when its COW?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
