DanielZhu58 commented on code in PR #6767:
URL: https://github.com/apache/hive/pull/6767#discussion_r4010702497
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatisticsManagementTask.java:
##########
@@ -58,6 +61,8 @@ public class StatisticsManagementTask extends ObjectStore
implements MetastoreTa
*/
public static final String STATISTICS_AUTO_DELETION_EXCLUDE_TBLPROPERTY =
"statistics.auto.deletion.exclude";
+ public static final String STATISTICS_AUTO_DELETION_EXCLUDE_DBPROPERTY =
Review Comment:
I prefer to keep these as two separate constants because they represent two
different scope, table level and database level.
STATISTICS_AUTO_DELETION_EXCLUDE_TBLPROPERTY is used for table parameters,
while STATISTICS_AUTO_DELETION_EXCLUDE_DBPROPERTY is used for database
parameters. Keeping separate names makes the call sites easier to read,
especially in the JDO projection where we check both table.parameters and
table.database.parameters.
This also keeps the code more future-proof in case we ever decide to use
different property keys for table-level and database-level exclusion. So the
string value is intentionally the same, but the constant names is intentionally
different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
