abstractdog commented on code in PR #6774:
URL: https://github.com/apache/hive/pull/6774#discussion_r4013934992
##########
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestHiveSchemaConverter.java:
##########
@@ -334,7 +334,7 @@ public void testMap() throws Exception {
"map<string,string>",
"message hive_schema {\n"
+ " optional group mapCol (MAP) {\n"
- + " repeated group key_value (MAP_KEY_VALUE) {\n"
+ + " repeated group key_value {\n"
Review Comment:
related, see description:
```
The TestHiveSchemaConverter changes follow from a Parquet 1.18 behavior
change:
ConversionPatterns.mapType no longer stamps the deprecated MAP_KEY_VALUE
annotation on a MAP's inner key_value group — the Parquet MAP standard treats
it as redundant.
```
https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-6774/1/pipeline
##########
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestHiveSchemaConverter.java:
##########
@@ -334,7 +334,7 @@ public void testMap() throws Exception {
"map<string,string>",
"message hive_schema {\n"
+ " optional group mapCol (MAP) {\n"
- + " repeated group key_value (MAP_KEY_VALUE) {\n"
+ + " repeated group key_value {\n"
Review Comment:
related, see description:
```
The TestHiveSchemaConverter changes follow from a Parquet 1.18 behavior
change:
ConversionPatterns.mapType no longer stamps the deprecated MAP_KEY_VALUE
annotation
on a MAP's inner key_value group — the Parquet MAP standard treats it as
redundant.
```
https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-6774/1/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
