abstractdog commented on code in PR #6779:
URL: https://github.com/apache/hive/pull/6779#discussion_r4014619418
##########
packaging/src/kubernetes/src/java/org/apache/hive/kubernetes/operator/util/HiveConfigBuilder.java:
##########
@@ -201,6 +201,17 @@ public static Map<String, String>
getTezSite(HiveClusterSpec spec, LlapSpec llap
tezProps.put(ConfigUtils.HIVE_LLAP_DAEMON_UMBILICAL_PORT_KEY,
ConfigUtils.HIVE_LLAP_DAEMON_UMBILICAL_PORT_DEFAULT);
+ // A standalone AM's LLAP plugins -- task scheduler, task communicator,
split location
+ // provider -- read tez-site, not hive-site. Users set these hive.llap
keys in the
+ // HiveServer2 overrides, so copy them across; an explicit tezAm override
below wins.
+ if (spec.hiveServer2().configOverrides() != null) {
Review Comment:
I can see something handled above separately, could it be removed after this
patch?
```
// Required by LlapTaskCommunicator — Tez's Configuration doesn't get
HiveConf defaults
tezProps.put(ConfigUtils.HIVE_LLAP_DAEMON_UMBILICAL_PORT_KEY,
ConfigUtils.HIVE_LLAP_DAEMON_UMBILICAL_PORT_DEFAULT);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
