difin opened a new pull request, #6789:
URL: https://github.com/apache/hive/pull/6789
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Hive wires up Iceberg REST server-side scan planning: when
`scan-planning-mode=server`, split planning can go through the REST catalog
(POST /plan) instead of only the serialized table snapshot on Tez/MR workers.
Adds a small `RestCatalogScanPlanning` helper for config and copying catalog
settings into job conf, and updates the Iceberg storage handler / input path to
reload a live REST table on executors where appropriate. Tests cover
configuration, job propagation, and embedded REST planning behavior.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
With a REST catalog that supports `POST /plan`, planning splits on the
driver/executor from deserialized `SerializableTable` metadata bypasses the
catalog server and can miss server-side optimizations. Operators who set
Iceberg’s server planning mode need Hive to honor it end-to-end, including
passing catalog connection settings to workers so executors can open a real
REST table and delegate `planTasks()` to the server.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducible
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. For REST Iceberg catalogs, operators can set
`iceberg.catalog.<catalog>.scan-planning-mode=server` (via `hive-site.xml` or
session SET) alongside existing REST catalog properties. When enabled, read
jobs that use the Iceberg input format can use server-side scan planning
instead of local planning from the serialized snapshot. Default behavior is
unchanged when the property is unset or not server. Hive and non-REST catalogs
are unaffected.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
`TestRestCatalogScanPlanning` — config keys, server-mode detection, job
propagation gating and copying.
`TestRestCatalogScanPlanningServerIT` — embedded REST catalog; Verifies that
`RESTTable` / `RESTTableScan` and `PlanTableScanRequest on planTasks()` are
used when file planning is on.
`TestHiveIcebergServerSideScanPlanning` — `resolveTableForScanPlanning` when
server mode is off or intra-txn metadata is set.
`TestHiveIcebergServerSideScanPlanningServerIT` — Tests that executor job
conf with/without propagated catalog props and table reload over REST.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
