dengzhhu653 commented on code in PR #6734: URL: https://github.com/apache/hive/pull/6734#discussion_r4021675612
########## standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/metastore/TestPersistenceContextEviction.java: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.metastore.metastore; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.metastore.ExecutionContextTestUtils; +import org.apache.hadoop.hive.metastore.HMSHandler; +import org.apache.hadoop.hive.metastore.MetaStoreTestUtils; +import org.apache.hadoop.hive.metastore.ObjectStore; +import org.apache.hadoop.hive.metastore.Warehouse; +import org.apache.hadoop.hive.metastore.annotation.MetastoreUnitTest; +import org.apache.hadoop.hive.metastore.api.MetaException; +import org.apache.hadoop.hive.metastore.api.NotificationEvent; +import org.apache.hadoop.hive.metastore.api.NotificationEventRequest; +import org.apache.hadoop.hive.metastore.api.NotificationEventResponse; +import org.apache.hadoop.hive.metastore.conf.MetastoreConf; +import org.apache.hadoop.hive.metastore.conf.MetastoreConf.ConfVars; +import org.apache.hadoop.hive.metastore.messaging.EventMessage; +import org.apache.hadoop.hive.metastore.model.MNotificationLog; +import org.apache.hadoop.hive.metastore.utils.MetaStoreServerUtils; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +import javax.jdo.PersistenceManager; +import javax.jdo.Query; +import java.util.List; +import java.util.UUID; + +/** + * Verifies batched metastore operations evict loaded JDO entities from the persistence context. + * Without eviction, long-lived RawStore instances (for example the DB notification cleaner thread) + * accumulate deleted entities in the L1 cache and can OOM. + */ +@Category(MetastoreUnitTest.class) +public class TestPersistenceContextEviction { + private static final int BATCH_SIZE = 3; + private static final int NUM_EVENTS = 12; + + private ObjectStore objectStore; + private Configuration conf; + private PersistenceManager pm; + + @Before + public void setUp() throws Exception { + conf = MetastoreConf.newMetastoreConf(); + MetastoreConf.setBoolVar(conf, ConfVars.HIVE_IN_TEST, true); + MetastoreConf.setLongVar(conf, MetastoreConf.ConfVars.EVENT_CLEAN_MAX_EVENTS, BATCH_SIZE); + MetastoreConf.setLongVar(conf, ConfVars.RAWSTORE_PARTITION_BATCH_SIZE, BATCH_SIZE); + MetaStoreTestUtils.setConfForStandloneMode(conf); + + String currentUrl = MetastoreConf.getVar(conf, ConfVars.CONNECT_URL_KEY); + currentUrl = currentUrl.replace(MetaStoreServerUtils.JUNIT_DATABASE_PREFIX, + String.format("%s_%s", MetaStoreServerUtils.JUNIT_DATABASE_PREFIX, UUID.randomUUID())); + MetastoreConf.setVar(conf, ConfVars.CONNECT_URL_KEY, currentUrl); + + objectStore = new ObjectStore(); + objectStore.setConf(conf); + HMSHandler.createDefaultCatalog(objectStore, new Warehouse(conf)); + pm = objectStore.createRawStoreBundle().getPersistentManager(); + } + + @Test + public void testExecutionContextCountsLoadedNotificationEvents() throws MetaException { + insertNotificationEvents(5, "payload"); + + objectStore.openTransaction(); + try { + Query query = pm.newQuery(MNotificationLog.class); + List<MNotificationLog> events = (List<MNotificationLog>) query.execute(); + pm.retrieveAll(events); + Assert.assertTrue("expected loaded events to remain in the persistence context", + ExecutionContextTestUtils.countCachedInstances(pm, MNotificationLog.class) >= 5); + } finally { + objectStore.rollbackTransaction(); + } + + Assert.assertEquals(0, ExecutionContextTestUtils.countCachedInstances(pm, MNotificationLog.class)); + } + + @Test + public void testCleanNotificationEventsEvictsCachedEntities() throws MetaException { + insertNotificationEvents(NUM_EVENTS, "x".repeat(50)); + + objectStore.openTransaction(); + try { + objectStore.cleanNotificationEvents(0); Review Comment: This is trying to validate if `cleanNotificationEvents` has an outer transaction, the deleted events remains in DataNucleus L1 cache, which causing this OOM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
