thomasrebele commented on code in PR #6766:
URL: https://github.com/apache/hive/pull/6766#discussion_r4024390800
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestMetastoreScheduledQueries.java:
##########
@@ -395,6 +388,86 @@ public void testSkip2() throws Exception {
}
}
+
+ @Test
+ public void testDisablePolicyUsesEndTime() throws Exception {
Review Comment:
I would prefer `testAutoDisablePolicyUsesEndTime`. A short explanation about
the goals of the test would be nice, e.g.,
> With autoDisableCount=2, skipCount=0, the ObjectStore algorithm looks at
the consecutive sequences of queries sorted by their end time, [exec2, exec1]
and [exec1, exec3], and as none of the sequences consists of only failures, the
autodisable count does not apply. So the scheduled query shall be kept enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
