deniskuzZ commented on code in PR #6773:
URL: https://github.com/apache/hive/pull/6773#discussion_r4036867066
##########
packaging/src/kubernetes/src/java/org/apache/hive/kubernetes/operator/reconciler/HiveClusterReconciler.java:
##########
@@ -577,6 +567,30 @@ private void patchReplicas(KubernetesClient client,
HiveCluster resource,
}
}
+ /**
+ * Emits an INFO log when the reconciler's server-side apply is about to
change the workload's
+ * replica count. Without this, an SSA-driven scale (a user editing
spec.llapClusters[i].replicas,
+ * a helm upgrade rewriting it) reaches the StatefulSet/Deployment silently
-- only the
+ * autoscaler path {@link #patchReplicas} logged its scales, so a plain
scale looked like the
+ * operator was doing nothing. Read failures are swallowed at DEBUG: the SSA
below runs either
+ * way, and a missing pre-scale line is not worth failing the reconcile over.
+ */
+ private void logReplicaChange(KubernetesClient client, String ns, String
workloadName,
Review Comment:
can we generalize log method or need both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
